deps: update V8 to 5.4.500.41 #9412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
approved these changes
Nov 2, 2016
| int32_t __tmp_##name = 0; \ | ||
| CHECK(args[index]->ToInt32(&__tmp_##name)); \ | ||
| CHECK(is_valid_language_mode(__tmp_##name)); \ | ||
| LanguageMode name = static_cast<LanguageMode>(__tmp_##name); |
There was a problem hiding this comment.
I confess to not understanding why this change is necessary. I'm going to guess it's got something to do with the InitializeVarGlobal intrinsic but the details elude me.
jasnell
approved these changes
Nov 2, 2016
|
LGTM |
|
I was waiting for the V8 CI job to work again. CI: https://ci.nodejs.org/job/node-test-pull-request/4817/ |
|
CI is green. Can I have a few LGTM for the new commit ? |
cjihrig
approved these changes
Nov 10, 2016
bnoordhuis
approved these changes
Nov 11, 2016
That's the plan. Going to land now... |
PR-URL: nodejs#9412 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
|
Landed in 0fa09b4 |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 11, 2016
PR-URL: #9412 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
V8
Description of change
Update V8 to the latest patch version.
/cc @nodejs/v8
Diff: v8/v8@5.4.500.36...5.4.500.40
CI: https://ci.nodejs.org/job/node-test-pull-request/4760/