Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-force-repl-with-eval #9460

Merged
merged 1 commit into from
Nov 6, 2016
Merged

test: fix flaky test-force-repl-with-eval #9460

merged 1 commit into from
Nov 6, 2016

Conversation

santigimeno
Copy link
Member

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Remove the timer just in case the test takes longer to complete.

It has already failed on the smartos bot: https://ci.nodejs.org/job/node-test-commit-smartos/5075/nodes=smartos14-64/consoleFull

not ok 324 parallel/test-force-repl-with-eval
# /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-64/test/parallel/test-force-repl-with-eval.js:10
#   throw new Error('timeout!');
#   ^
# 
# Error: timeout!
#     at Timeout._onTimeout (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-64/test/parallel/test-force-repl-with-eval.js:10:9)
#     at ontimeout (timers.js:365:14)
#     at tryOnTimeout (timers.js:237:5)
#     at Timer.listOnTimeout (timers.js:207:5)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 4, 2016
@santigimeno santigimeno added repl Issues and PRs related to the REPL subsystem. smartos Issues and PRs related to the SmartOS platform. labels Nov 4, 2016
Trott
Trott approved these changes Nov 5, 2016
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@santigimeno
test: fix flaky test-force-repl-with-eval
686b334 
Remove the timer just in case the test takes longer to complete.

PR-URL: nodejs#9460
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@santigimeno santigimeno merged commit 686b334 into nodejs:master Nov 6, 2016
evanlucas pushed a commit that referenced this pull request Nov 7, 2016
@santigimeno @evanlucas
test: fix flaky test-force-repl-with-eval
f640baf 
Remove the timer just in case the test takes longer to complete.

PR-URL: #9460
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@evanlucas evanlucas mentioned this pull request Nov 7, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
@santigimeno
test: fix flaky test-force-repl-with-eval
aaf7834 
Remove the timer just in case the test takes longer to complete.

PR-URL: #9460
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 22, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
repl Issues and PRs related to the REPL subsystem. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@santigimeno @Trott @targos @cjihrig @MylesBorins @nodejs-github-bot