doc: fix link to cli.md in vm.md #9481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like the link to cli.md is missing in vm.md: https://nodejs.org/api/vm.html#vm_vm_runindebugcontext_code Added the link which can be verified by using the following commands: $ make doc $ open out/doc/api/vm.html
nodejs-github-bot
added
doc
jasnell
approved these changes
Nov 7, 2016
|
Would it work to change |
Ah, that works and is more inline with what the other links do. Thanks for that! |
cjihrig
approved these changes
Nov 8, 2016
danbev
added a commit
to danbev/node
that referenced
this pull request
Nov 8, 2016
Looks like the link to cli.md is missing in vm.md: https://nodejs.org/api/vm.html#vm_vm_runindebugcontext_code Added the link which can be verified by using the following commands: $ make doc $ open out/doc/api/vm.html PR-URL: nodejs#9481 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 5734361 |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 15, 2016
Looks like the link to cli.md is missing in vm.md: https://nodejs.org/api/vm.html#vm_vm_runindebugcontext_code Added the link which can be verified by using the following commands: $ make doc $ open out/doc/api/vm.html PR-URL: #9481 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 15, 2016
Looks like the link to cli.md is missing in vm.md: https://nodejs.org/api/vm.html#vm_vm_runindebugcontext_code Added the link which can be verified by using the following commands: $ make doc $ open out/doc/api/vm.html PR-URL: #9481 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
doc
Description of change
Looks like the link for cli.md is missing:
https://nodejs.org/api/vm.html#vm_vm_runindebugcontext_code
Added the link which can be verified by using the following commands: