test: refactor inspector-helper.js #9499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two instances of `setTimeout()` called without a duration in `inspector-helper.js`. Change to `setImmediate()` for clarity that it isn't a mistake.
Trott
added
test
cjihrig
approved these changes
Nov 7, 2016
jasnell
approved these changes
Nov 7, 2016
eugeneo
approved these changes
Nov 7, 2016
princejwesley
approved these changes
Nov 7, 2016
lpinca
approved these changes
Nov 8, 2016
|
Landed in 103858e |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Nov 10, 2016
There are two instances of `setTimeout()` called without a duration in `inspector-helper.js`. Change to `setImmediate()` for clarity that it isn't a mistake. PR-URL: nodejs#9499 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Nov 22, 2016
There are two instances of `setTimeout()` called without a duration in `inspector-helper.js`. Change to `setImmediate()` for clarity that it isn't a mistake. PR-URL: #9499 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
There are two instances of `setTimeout()` called without a duration in `inspector-helper.js`. Change to `setImmediate()` for clarity that it isn't a mistake. PR-URL: nodejs#9499 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
There are two instances of `setTimeout()` called without a duration in `inspector-helper.js`. Change to `setImmediate()` for clarity that it isn't a mistake. PR-URL: #9499 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
There are two instances of
setTimeout()called without a duration ininspector-helper.js. Change tosetImmediate()for clarity that itisn't a mistake.
/cc @eugeneo