test: refactor test-next-tick-error-spin #9537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use common.mustCall() * setTimeout() -> setImmediate() * assert() -> assert.strictEqual() * var -> const * remove unneeded console.log() * remove commented-out code
cjihrig
approved these changes
Nov 11, 2016
Fishrock123
reviewed
Nov 11, 2016
| stdio: 'pipe'//'inherit' | ||
| }); | ||
| var timer = setTimeout(function() { | ||
| const timer = setTimeout(function() { |
There was a problem hiding this comment.
why can't this be an immediate?
There was a problem hiding this comment.
why can't this be an immediate?
??? The test will fail if you do that (or if you reduce the timeout too much from 3000ms) because the timer will fire before the spawned process has done its thing.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Nov 12, 2016
* use common.mustCall() * setTimeout() -> setImmediate() * assert() -> assert.strictEqual() * var -> const * remove unneeded console.log() * remove commented-out code PR-URL: nodejs#9537 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in c7976b5 |
addaleax
pushed a commit
that referenced
this pull request
Nov 22, 2016
* use common.mustCall() * setTimeout() -> setImmediate() * assert() -> assert.strictEqual() * var -> const * remove unneeded console.log() * remove commented-out code PR-URL: #9537 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
* use common.mustCall() * setTimeout() -> setImmediate() * assert() -> assert.strictEqual() * var -> const * remove unneeded console.log() * remove commented-out code PR-URL: nodejs#9537 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
* use common.mustCall() * setTimeout() -> setImmediate() * assert() -> assert.strictEqual() * var -> const * remove unneeded console.log() * remove commented-out code PR-URL: #9537 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
* use common.mustCall() * setTimeout() -> setImmediate() * assert() -> assert.strictEqual() * var -> const * remove unneeded console.log() * remove commented-out code PR-URL: #9537 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
* use common.mustCall() * setTimeout() -> setImmediate() * assert() -> assert.strictEqual() * var -> const * remove unneeded console.log() * remove commented-out code PR-URL: #9537 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test process domain timers
Description of change