-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix typo about cluster doc, (eg. -> e.g.) #9568
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
cluster
Issues and PRs related to the cluster subsystem.
doc
Issues and PRs related to the documentations.
labels
Nov 12, 2016
silverwind
approved these changes
Nov 12, 2016
cjihrig
approved these changes
Nov 12, 2016
lpinca
approved these changes
Nov 12, 2016
shigeki
approved these changes
Nov 13, 2016
Thanks. Landed in 5d168d728c13a027b484bbb0e92b67198454a565. |
shigeki
pushed a commit
that referenced
this pull request
Nov 13, 2016
Fixes: nodejs/code-and-learn#58 PR-URL: #9568 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Sorry, this had an another commit that has not been approved yet. |
addaleax
pushed a commit
that referenced
this pull request
Nov 22, 2016
Fixes: nodejs/code-and-learn#58 PR-URL: #9568 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 13, 2016
Fixes: nodejs/code-and-learn#58 PR-URL: #9568 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 13, 2016
Fixes: nodejs/code-and-learn#58 PR-URL: #9568 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Fixes: nodejs/code-and-learn#58 PR-URL: #9568 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Fixes: nodejs/code-and-learn#58 PR-URL: #9568 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Description of change
fix eg. to e.g. doc/cluster.md