-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: reduce tarball size by 8-10% #961
Conversation
Slim the tarballs further by removing examples, documentation and test for third party libraries. Also switch to checkout-index versus archive so we avoid using tar.
fwiw, we might want to make sure we're properly
|
I'm +1 on all of this and also for removing wrk--as long as we introduce instructions for installing it and/or a check in the I'd like to hear from contributors & TC members who have been around a while because there could be historical or other context that impacts on this. /cc @iojs/tc |
+1 |
Thanks for the feedback. I'll create an issue to discuss "the bigger question" as well as a PR for removing wrk for review. |
mkdir -p $(TARNAME)/doc/api | ||
cp doc/iojs.1 $(TARNAME)/doc/iojs.1 | ||
cp -r out/doc/api/* $(TARNAME)/doc/api/ | ||
rm -rf $(TARNAME)/deps/v8/test # too big | ||
rm -rf $(TARNAME)/deps/v8/{test,samples,tools/profviz} # too big |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also include testing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, there's heaps of small stuff that we can start picking off. For now I focused on the bigger folders/items. I can go bananas (as in, do a clean sweep) at a later stage, but I prefer talking about our intentions first.
LGTM, no comments. |
See #982 for |
LGTM, I'll merge this today unless there are objections in the meantime |
Slim the tarballs further by removing examples, documentation and test for third party libraries. Also switch to checkout-index versus archive so we avoid using tar. PR-URL: #961 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org>
landed @ b8310cb, thanks @jbergstroem! |
Slim the tarballs further by removing examples, documentation and test for third party libraries. Also switch to checkout-index versus archive so we avoid using tar.
"Verified" by using a generated tarball to configure, compile and test io.js.
Beyond this, it'll get tricker to further reduce the size. A few things to consider:
make bench-http
requirestools/wrk
which is bundled (3.9mb) but a lot of benchmarks also assumesab
is available. Perhaps dropwrk
from our bundle and make the same assumption?