doc: small improvements in readline code examples #9628
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Consistent template literals in
console.log()
.=== instead of ==.
const instead of var.
I am not sure about these two fragments:
In the Use of the completer Function
a. Should it be
(c) => c.indexOf(line) == 0
or is this a case ofno-confusing-arrow
eslint rule?b. Should a semicolon be added after
0
if the current variant remains?In the readline.emitKeypressEvents(stream[, interface])
Should it be in one line (like the similar fragment in the Event: 'SIGINT')?
If these ones should be somehow addressed, please, let me know.