-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: child_process documentation for stdio #9637
Conversation
Your git author information is You can do so via: git config --global user.name "J. Random User" Then git commit --amend --reset-author
git push origin head --force |
144cc43
to
733cd14
Compare
@Fishrock123 I've updated with full name... Thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You commit message should describe the changes, it doesn't now.
I suggest something like:
doc: child_process .stdio accepts an Array type
733cd14
to
a4a4135
Compare
@sam-github thanks, I've updated the commit message. |
@skovhus I'm sorry, I typed too quickly, and you accepted my suggestion too quickly.... it's the |
Document that `execFileSync`, `execSync` and `spawnSync` also supports `stdio` as an Array. Fixes: nodejs#9636
a4a4135
to
cd5b9d8
Compare
@sam-github my bad. Should be all right now. |
Thanks! Landed in 6df167c. |
Document that `execFileSync`, `execSync` and `spawnSync` also support `stdio` as an Array. PR-URL: #9637 Fixes: #9636 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <sam@strongloop.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Thanks. When are the docs released? Would that be with the next release of node or do you update existing documentation? |
The docs under https://nodejs.org/docs/ always refer to released versions and are fixed for a specific released version.
Generally, yes – but that’s only scheduled 3 days from now. It would be awesome if you could check for which release lines (v4.x, v6.x, v7.x) this updated documentation applies so that we know to which of these it should be applied, too. |
@addaleax thanks for clarifying.
I just checked that this documentation update applies for v4-7. So should I do a pull request where this is cherry picked into the |
@skovhus Since this doesn’t apply cleanly to v4.x, I think that would be appreciated; you’ll want to target the v5.x is no longer maintained and this cherry-picks cleanly onto the v6.x and v7.x staging branches, so there’s nothing to do there. :) |
@addaleax ok, I've made a pull for updating |
@skovhus thanks! :) |
Document that `execFileSync`, `execSync` and `spawnSync` also support `stdio` as an Array. PR-URL: #9637 Fixes: #9636 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <sam@strongloop.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Document that `execFileSync`, `execSync` and `spawnSync` also support `stdio` as an Array. PR-URL: #9637 Fixes: #9636 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <sam@strongloop.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Document that `execFileSync`, `execSync` and `spawnSync` also support `stdio` as an Array. PR-URL: #9637 Fixes: #9636 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <sam@strongloop.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Summary: This fixes #2824 I would wait merging it before nodejs/node#9637 has been approved. Closes #2825 Differential Revision: D4268009 Pulled By: gabelevi fbshipit-source-id: 1493ee7393516792fc08581cf0c71bc719c85f57
Checklist
Affected core subsystem(s)
doc
Description of change
Document that
execFileSync
,execSync
andspawnSync
also supportsstdio
as an Array.execFileSync
,execSync
andspawnSync
all ends up here, where the options are accepted as string or array. See https://github.com/nodejs/node/blob/master/lib/internal/child_process.js#L758Fixes: #9636