doc: fix process.stdout reference to console.log #964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| console.log = function(d) { | ||
| process.stdout.write(d + '\n'); | ||
| Console.prototype.log = function() { | ||
| this._stdout.write(util.format.apply(this, arguments) + '\n'); |
There was a problem hiding this comment.
Not a good example anymore, it doesn't use process.stdout
There was a problem hiding this comment.
oh my, I overlooked that - so it'd make sense to just remove it altogether, wouldn't it?
There was a problem hiding this comment.
I think we should leave it as is. Maybe reword caption to make it clear that it is not how actual console.log is implemented, but an example of how it could be implemented
brendanashworth
force-pushed
the
fix-process-stdout-docs
branch
from
ca5b099
to
969ff97
Compare
This commit changes the word introduction to the code block to be explicitly correct, and changes the `d` variable to `msg` for clarity.
brendanashworth
force-pushed
the
fix-process-stdout-docs
branch
from
969ff97
to
0435844
Compare
|
@vkurchatkin changed per your comments, how does it look now? |
|
LGTM |
1 similar comment
|
LGTM |
brendanashworth
added a commit
that referenced
this pull request
Feb 26, 2015
This commit changes the word introduction to the code block to be explicitly correct, and changes the `d` variable to `msg` for clarity. PR-URL: #964 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Nicu Micleușanu <micnic90@gmail.com> Reviewed-By: Vladimir Kurchatkin <vladimir.kurchatkin@gmail.com>
|
Thanks, landed in 2e2cf81 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the word introduction to the code block to be
explicitly correct, and changes the
dvariable tomsgfor clarity.