build: default to ppc64 on AIX #9645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
|
@bnoordhuis Do you know how make/gmake decides which C compiler to use?
I know you can use export CC=`which gcc`
export CXX=`which g++`but if there's an easy way to set defaults then that'd be useful. |
|
AIX user space defaults to 32 bit. IBM XLC compiler on AIX defaults to 32 bit. For compatibility, 32 bit remains the default on AIX for GCC. GCC had been defining PPC on AIX. In 64 bit mode (-maix64), GCC added definitions of PPC64 and powerpc64 for compatibility with Linux on Power starting with release GCC 6. |
mscdex
added
aix
|
@gibfahn: regarding gcc detection: https://github.com/nodejs/node/blob/master/configure#L14..L17 |
|
@gibfahn isn't cc symlinked to gcc on aix? |
|
@jbergstroem Yep, that configure step works fine, however those variables don't seem to be passed on to the make command. I don't think I'm pretty sure we're specifying |
|
Hm. Might be a Gyp issue |
mhdawson
approved these changes
Nov 17, 2016
jasnell
approved these changes
Nov 18, 2016
gibfahn
force-pushed
the
pr-configure-aix
branch
from
b95397d
to
e7eb644
Compare
The ./configure python script searches `gcc -dM -E -` for the ARCH flags. On AIX, gcc builds in 32 bit mode by default prior to gcc v6, so you don't get the __PPC64__ flag unless you run `gcc -maix64 -dM -E -`. We don't support ppc 32 bit for any OS, so always use ppc64 as the host_arch. PR-URL: nodejs#9645 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
force-pushed
the
pr-configure-aix
branch
from
e7eb644
to
515b1f3
Compare
addaleax
pushed a commit
that referenced
this pull request
Nov 22, 2016
The ./configure python script searches `gcc -dM -E -` for the ARCH flags. On AIX, gcc builds in 32 bit mode by default prior to gcc v6, so you don't get the __PPC64__ flag unless you run `gcc -maix64 -dM -E -`. We don't support ppc 32 bit for any OS, so always use ppc64 as the host_arch. PR-URL: #9645 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
The ./configure python script searches `gcc -dM -E -` for the ARCH flags. On AIX, gcc builds in 32 bit mode by default prior to gcc v6, so you don't get the __PPC64__ flag unless you run `gcc -maix64 -dM -E -`. We don't support ppc 32 bit for any OS, so always use ppc64 as the host_arch. PR-URL: #9645 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
The ./configure python script searches `gcc -dM -E -` for the ARCH flags. On AIX, gcc builds in 32 bit mode by default prior to gcc v6, so you don't get the __PPC64__ flag unless you run `gcc -maix64 -dM -E -`. We don't support ppc 32 bit for any OS, so always use ppc64 as the host_arch. PR-URL: #9645 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
The ./configure python script searches `gcc -dM -E -` for the ARCH flags. On AIX, gcc builds in 32 bit mode by default prior to gcc v6, so you don't get the __PPC64__ flag unless you run `gcc -maix64 -dM -E -`. We don't support ppc 32 bit for any OS, so always use ppc64 as the host_arch. PR-URL: #9645 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
The ./configure python script searches `gcc -dM -E -` for the ARCH flags. On AIX, gcc builds in 32 bit mode by default prior to gcc v6, so you don't get the __PPC64__ flag unless you run `gcc -maix64 -dM -E -`. We don't support ppc 32 bit for any OS, so always use ppc64 as the host_arch. PR-URL: #9645 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
build
Description of change
The ./configure python script searches
gcc -dM -E -for the ARCHflags. On AIX, gcc builds in 32 bit mode by default prior to gcc v6, so
you don't get the flag unless you run
gcc -maix64 -dM -E -.We don't support ppc 32 bit for any OS, so always use ppc64 as the
host_arch.
cc/ @edelsohn (who confirmed that
__PPC64__wasn't available below gcc v6)cc/ @nodejs/platform-aix