Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url: add a got host pattern in url.js #9653

Closed
wants to merge 1 commit into from

Conversation

AxelMonroyX
Copy link
Contributor

@AxelMonroyX AxelMonroyX commented Nov 17, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

Add a hostPattern variable for readable purposes

@nodejs-github-bot nodejs-github-bot added the url Issues and PRs related to the legacy built-in url module. label Nov 17, 2016
@AxelMonroyX AxelMonroyX changed the title lib: add a got host pattern in url.js url: add a got host pattern in url.js Nov 17, 2016
@mscdex
Copy link
Contributor

mscdex commented Nov 17, 2016

Maybe hostPattern is a better, shorter name?

Also, it seems your branch has some conflicts.

@AxelMonroyX
Copy link
Contributor Author

@mscdex Ready

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

Add a hostPattern variable for readable purposes

@mscdex
Copy link
Contributor

mscdex commented Nov 18, 2016

LGTM

@targos
Copy link
Member

targos commented Nov 19, 2016

@jasnell
Copy link
Member

jasnell commented Dec 5, 2016

@AxelMonroyX ... can I ask you to please squash the commits. this is not landing cleanly on master with the merge commit there.

Add a hostPattern variable for readable purposes
@AxelMonroyX
Copy link
Contributor Author

@jasnell Ready

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

Add a hostPattern variable for readable purposes

jasnell pushed a commit that referenced this pull request Dec 6, 2016
Add a hostPattern variable for readable purposes

PR-URL: #9653
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@jasnell
Copy link
Member

jasnell commented Dec 6, 2016

Landed in 1be73e8. Thank you!

Fishrock123 pushed a commit that referenced this pull request Dec 13, 2016
Add a hostPattern variable for readable purposes

PR-URL: #9653
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@evanlucas
Copy link
Contributor

Closing since this has landed. Thanks!

@evanlucas evanlucas closed this Dec 14, 2016
@italoacasas italoacasas mentioned this pull request Dec 15, 2016
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
Add a hostPattern variable for readable purposes

PR-URL: #9653
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
Add a hostPattern variable for readable purposes

PR-URL: #9653
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2017
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
Add a hostPattern variable for readable purposes

PR-URL: #9653
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants