-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
url: add a got host pattern in url.js #9653
Conversation
Maybe Also, it seems your branch has some conflicts. |
@mscdex Ready Checklist
Description of changeAdd a hostPattern variable for readable purposes |
LGTM |
@AxelMonroyX ... can I ask you to please squash the commits. this is not landing cleanly on master with the merge commit there. |
Add a hostPattern variable for readable purposes
daf841a
to
1b4348a
Compare
@jasnell Ready Checklist
Description of changeAdd a hostPattern variable for readable purposes |
Add a hostPattern variable for readable purposes PR-URL: #9653 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Landed in 1be73e8. Thank you! |
Add a hostPattern variable for readable purposes PR-URL: #9653 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Closing since this has landed. Thanks! |
Add a hostPattern variable for readable purposes PR-URL: #9653 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Add a hostPattern variable for readable purposes PR-URL: #9653 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Add a hostPattern variable for readable purposes PR-URL: #9653 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Checklist
make -j8 test
(UNIX), orvcbuild test nosign
(Windows) passesDescription of change
Add a hostPattern variable for readable purposes