Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix memory leaks in malloc cctests #9667

Merged
merged 1 commit into from
Nov 18, 2016
Merged

test: fix memory leaks in malloc cctests #9667

merged 1 commit into from
Nov 18, 2016

Conversation

bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Nov 17, 2016 •
edited
Loading

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 17, 2016
@mscdex mscdex added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 17, 2016
addaleax
addaleax approved these changes Nov 17, 2016
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just curious, is this making any problems right now?

@bnoordhuis
Copy link
Member Author

No, not unless you run valgrind.

@bnoordhuis
test: fix memory leaks in malloc cctests
b80f05e 
Make cctest valgrind-clean again by freeing heap-allocated memory.
Overlooked in commit ea94086 ("src: provide allocation + nullptr check
shortcuts.")

PR-URL: nodejs#9667
Refs: nodejs#8482
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@bnoordhuis bnoordhuis closed this Nov 18, 2016
@bnoordhuis bnoordhuis deleted the cctest-valgrind branch November 18, 2016 20:59
@bnoordhuis bnoordhuis merged commit b80f05e into nodejs:master Nov 18, 2016
addaleax pushed a commit that referenced this pull request Nov 22, 2016
@bnoordhuis @addaleax
test: fix memory leaks in malloc cctests
a29be52 
Make cctest valgrind-clean again by freeing heap-allocated memory.
Overlooked in commit ea94086 ("src: provide allocation + nullptr check
shortcuts.")

PR-URL: #9667
Refs: #8482
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@MylesBorins
Copy link
Contributor

@bnoordhuis should we backport this?

@addaleax
Copy link
Member

@thealphanerd I don’t think this applies to v4.x, but for v6 yes

@MylesBorins
Copy link
Contributor

@addaleax this does not land cleanly on v6, manual backport?

@MylesBorins
Copy link
Contributor

ping @addaleax

@addaleax
Copy link
Member

adding dont-land-on-v6.x because it’s really not worth the trouble, I’d say

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@santigimeno santigimeno santigimeno approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@bnoordhuis @MylesBorins @addaleax @jasnell @santigimeno @cjihrig @mscdex @nodejs-github-bot