Make --shared on AIX work (shared library support)

configure

@@ -848,7 +848,14 @@ def configure_node(o):
  o['variables']['node_no_browser_globals'] = b(options.no_browser_globals)
  o['variables']['node_shared'] = b(options.shared)
  node_module_version = getmoduleversion.get_version()
- shlib_suffix = '%s.dylib' if sys.platform == 'darwin' else 'so.%s'
+
+ if sys.platform == 'darwin':
+ shlib_suffix = '%s.dylib'
+ elif sys.platform.startswith('aix'):
+ shlib_suffix = '%s.a'
+ else:
+ shlib_suffix = 'so.%s'
+
  shlib_suffix %= node_module_version
  o['variables']['node_module_version'] = int(node_module_version)
  o['variables']['shlib_suffix'] = shlib_suffix

node.gyp

@@ -928,7 +928,15 @@
  'targets': [
  {
  'target_name': 'node',
- 'type': 'executable',
+ 'conditions': [
+ ['node_shared=="true"', {
+ 'type': 'shared_library',
+ 'ldflags': ['--shared'],
+ 'product_extension': '<(shlib_suffix)',
+ }, {
+ 'type': 'executable', 
+ }],
+ ], 
  'dependencies': ['<(node_core_target_name)', 'node_exp'],
 
  'include_dirs': [

tools/gyp/AUTHORS

@@ -1,9 +1,10 @@
 # Names should be added to this file like so:
 # Name or Organization <email address>
 
-Google Inc.
-Bloomberg Finance L.P.
-Yandex LLC
+Google Inc. <*@google.com>
+Bloomberg Finance L.P. <*@bloomberg.net>
+IBM Inc. <*@*.ibm.com>
+Yandex LLC <*@yandex-team.ru>
 
 Steven Knight <knight@baldmt.com>
 Ryan Norton <rnorton10@gmail.com>

tools/gyp/PRESUBMIT.py

@@ -73,23 +73,15 @@
 ]
 
 
-def CheckChangeOnUpload(input_api, output_api):
- report = []
- report.extend(input_api.canned_checks.PanProjectChecks(
- input_api, output_api))
- return report
-
-
-def CheckChangeOnCommit(input_api, output_api):
- report = []
-
+def _LicenseHeader(input_api):
  # Accept any year number from 2009 to the current year.
  current_year = int(input_api.time.strftime('%Y'))
  allowed_years = (str(s) for s in reversed(xrange(2009, current_year + 1)))
+
  years_re = '(' + '|'.join(allowed_years) + ')'
 
  # The (c) is deprecated, but tolerate it until it's removed from all files.
- license = (
+ return (
  r'.*? Copyright (\(c\) )?%(year)s Google Inc\. All rights reserved\.\n'
  r'.*? Use of this source code is governed by a BSD-style license that '
  r'can be\n'
@@ -98,8 +90,18 @@ def CheckChangeOnCommit(input_api, output_api):
  'year': years_re,
  }
 
+def CheckChangeOnUpload(input_api, output_api):
+ report = []
+ report.extend(input_api.canned_checks.PanProjectChecks(
+ input_api, output_api, license_header=_LicenseHeader(input_api)))
+ return report
+
+
+def CheckChangeOnCommit(input_api, output_api):
+ report = []
+
  report.extend(input_api.canned_checks.PanProjectChecks(
- input_api, output_api, license_header=license))
+ input_api, output_api, license_header=_LicenseHeader(input_api)))
  report.extend(input_api.canned_checks.CheckTreeIsOpen(
  input_api, output_api,
  'http://gyp-status.appspot.com/status',

tools/gyp/pylib/gyp/generator/make.py

@@ -92,7 +92,10 @@ def CalculateVariables(default_variables, params):
  if flavor == 'android':
  operating_system = 'linux' # Keep this legacy behavior for now.
  default_variables.setdefault('OS', operating_system)
- default_variables.setdefault('SHARED_LIB_SUFFIX', '.so')
+ if flavor == 'aix':
+ default_variables.setdefault('SHARED_LIB_SUFFIX', '.a')
+ else:
+ default_variables.setdefault('SHARED_LIB_SUFFIX', '.so')
  default_variables.setdefault('SHARED_LIB_DIR','$(builddir)/lib.$(TOOLSET)')
  default_variables.setdefault('LIB_DIR', '$(obj).$(TOOLSET)')
 
@@ -1349,7 +1352,10 @@ def ComputeOutputBasename(self, spec):
  if target[:3] == 'lib':
  target = target[3:]
  target_prefix = 'lib'
- target_ext = '.so'
+ if self.flavor == 'aix':
+ target_ext = '.a'
+ else:
+ target_ext = '.so'
  elif self.type == 'none':
  target = '%s.stamp' % target
  elif self.type != 'executable':