-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix crypto "decipher.setAAD()" typo #9782
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix crypto "decipher.setAAD()" typo
nodejs-github-bot
added
crypto
Issues and PRs related to the crypto subsystem.
doc
Issues and PRs related to the documentations.
labels
Nov 24, 2016
fix crypto "decipher.setAAD()" typo |
LGTM |
1 similar comment
LGTM |
@Amery2010 Update commit msg as |
LGTM, other than the commit message format |
italoacasas
pushed a commit
that referenced
this pull request
Nov 24, 2016
PR-URL: #9782 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Landed in 7eb2e3f I fix the commit message. Thanks for the contribution @Amery2010 |
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
PR-URL: #9782 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
PR-URL: #9782 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
PR-URL: #9782 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #9782 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #9782 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
Description of change
fix crypto "decipher.setAAD()" typo