Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: backport fix to v8 bug in toUpper('ç') #9828

Closed
wants to merge 2 commits into from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Nov 28, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

deps - v8 floating patch

Description of change

Fixes: #9785

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Nov 28, 2016
@srl295 srl295 force-pushed the fix-ç branch 2 times, most recently from 54298b5 to b1a4f0d Compare November 28, 2016 19:31
@srl295 srl295 self-assigned this Nov 28, 2016
@srl295 srl295 added i18n-api Issues and PRs related to the i18n implementation. semver-minor PRs that contain new features and should be released in the next minor version. labels Nov 28, 2016
@MylesBorins
Copy link
Contributor

@srl295 AFAIK we will not land floating patches on V8 that have not landed upstream.

once this has landed upstream it can be backported using this guide

/cc @nodejs/v8 @ofrobots

// Always run these. They should always pass, even if the locale
// param is ignored.
assert.strictEqual('Ç'.toLocaleLowerCase('el'), 'ç');
assert.strictEqual('Ç'.toLocaleLowerCase('tr'), 'ç');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to try 'lt' as well.
Otherwise, LGTM

@srl295
Copy link
Member Author

srl295 commented Nov 28, 2016

@thealphanerd thanks. will wait for upstream fix. Version wise, this may need a backport . @ofrobots thanks, fixed.

@ofrobots
Copy link
Contributor

@srl295 why is this labelled with semver-minor. Seems like a bug fix to me.

@srl295 srl295 added confirmed-bug Issues with confirmed bugs. and removed semver-minor PRs that contain new features and should be released in the next minor version. labels Nov 28, 2016
@jungshik
Copy link

https://codereview.chromium.org/2533033003/ is a v8 CL to fix this issue.

@srl295
Copy link
Member Author

srl295 commented Nov 29, 2016

@ofrobots
Copy link
Contributor

This should be okay to review for landing onto master and v7.x – V8 5.4. The the fix has landed upstream and upstream is no longer maintaining V8 5.4. The fix should be formatted as a cherry-pick as per this guide however: https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md

I have requested a upstream merge for 5.5 and 5.6.

Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix should be formatted as a cherry-pick as per this guide: https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md

@MylesBorins
Copy link
Contributor

@srl295 are you able to update this following the guide mentioned above? It will need to include the original commit information, and also bump the V8 patch number.

I'm more than happy to take it over if you like.

@srl295
Copy link
Member Author

srl295 commented Dec 30, 2016

@thealphanerd Let me see if I can do it…

@srl295
Copy link
Member Author

srl295 commented Dec 30, 2016

@ofrobots and @thealphanerd (and anyone) PTAL, updated as per guide mentioned above.

@gibfahn
Copy link
Member

gibfahn commented Dec 30, 2016

@srl295 I think you need to bump the patch number in v8-version.h (as in #10525).

@MylesBorins MylesBorins self-assigned this Dec 30, 2016
@srl295
Copy link
Member Author

srl295 commented Dec 30, 2016

@thealphanerd OK thanks. DO you want to land it in master also? If so please go ahead.

@MylesBorins
Copy link
Contributor

once @ofrobots approves anyone can it 😁

@srl295 srl295 changed the title deps: work around v8 bug in toUpper('ç') deps: backport fix to v8 bug in toUpper('ç') Dec 30, 2016
@srl295
Copy link
Member Author

srl295 commented Dec 30, 2016

@thealphanerd ok… also fixed the title, as it's no longer a workaround.

Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jasnell
Copy link
Member

jasnell commented Jan 6, 2017

@MylesBorins
Copy link
Contributor

CI passed despite reporting that arm failed.

Landed in 6d3c5b7...e9b7291

@MylesBorins MylesBorins closed this Jan 6, 2017
MylesBorins pushed a commit that referenced this pull request Jan 6, 2017
Original commit message:
  Fix the uppercasing of U+00E7(ç) and U+00F7(÷)
  Due to a typo in runtime-i18n.js, 'ç'(U+00E7) was not uppercased
  while '÷'(U+00F7) was incorrectly uppercased to '×'(U+00D7).

  Add a comprehensive test for Latin-1 supplemental block
  (U+00A0 ~ U+00FF). (they're special-cased for speed-up and
  needs to have a test for the range.).

  TEST=intl/general/case-mapping
  BUG=v8:5681

  Review-Url: https://codereview.chromium.org/2533033003
  Cr-Commit-Position: refs/heads/master@{#41331}

PR-URL: #9828
Fixes: #9785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 6, 2017
* add test for ç/Ç in various locales

PR-URL: #9828
Fixes: #9785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins
Copy link
Contributor

This does not appear to affect v4 or v6 and as such I have added the dont-land labels. Feel free to modify if I am incorrect

@ofrobots
Copy link
Contributor

ofrobots commented Jan 11, 2017

Merged upstream into V8 5.5 and 5.6.

italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
* add test for ç/Ç in various locales

PR-URL: nodejs#9828
Fixes: nodejs#9785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 19, 2017
* add test for ç/Ç in various locales

PR-URL: nodejs#9828
Fixes: nodejs#9785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@srl295 srl295 deleted the fix-ç branch January 19, 2017 01:38
@targos targos removed the confirmed-bug Issues with confirmed bugs. label Jan 28, 2017
targos pushed a commit that referenced this pull request Jan 28, 2017
Original commit message:
  Fix the uppercasing of U+00E7(ç) and U+00F7(÷)
  Due to a typo in runtime-i18n.js, 'ç'(U+00E7) was not uppercased
  while '÷'(U+00F7) was incorrectly uppercased to '×'(U+00D7).

  Add a comprehensive test for Latin-1 supplemental block
  (U+00A0 ~ U+00FF). (they're special-cased for speed-up and
  needs to have a test for the range.).

  TEST=intl/general/case-mapping
  BUG=v8:5681

  Review-Url: https://codereview.chromium.org/2533033003
  Cr-Commit-Position: refs/heads/master@{#41331}

PR-URL: #9828
Fixes: #9785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
targos pushed a commit that referenced this pull request Jan 28, 2017
* add test for ç/Ç in various locales

PR-URL: #9828
Fixes: #9785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
Original commit message:
  Fix the uppercasing of U+00E7(ç) and U+00F7(÷)
  Due to a typo in runtime-i18n.js, 'ç'(U+00E7) was not uppercased
  while '÷'(U+00F7) was incorrectly uppercased to '×'(U+00D7).

  Add a comprehensive test for Latin-1 supplemental block
  (U+00A0 ~ U+00FF). (they're special-cased for speed-up and
  needs to have a test for the range.).

  TEST=intl/general/case-mapping
  BUG=v8:5681

  Review-Url: https://codereview.chromium.org/2533033003
  Cr-Commit-Position: refs/heads/master@{nodejs#41331}

PR-URL: nodejs#9828
Fixes: nodejs#9785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
* add test for ç/Ç in various locales

PR-URL: nodejs#9828
Fixes: nodejs#9785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
Original commit message:
  Fix the uppercasing of U+00E7(ç) and U+00F7(÷)
  Due to a typo in runtime-i18n.js, 'ç'(U+00E7) was not uppercased
  while '÷'(U+00F7) was incorrectly uppercased to '×'(U+00D7).

  Add a comprehensive test for Latin-1 supplemental block
  (U+00A0 ~ U+00FF). (they're special-cased for speed-up and
  needs to have a test for the range.).

  TEST=intl/general/case-mapping
  BUG=v8:5681

  Review-Url: https://codereview.chromium.org/2533033003
  Cr-Commit-Position: refs/heads/master@{nodejs#41331}

PR-URL: nodejs#9828
Fixes: nodejs#9785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
* add test for ç/Ç in various locales

PR-URL: nodejs#9828
Fixes: nodejs#9785
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n-api Issues and PRs related to the i18n implementation. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The letter 'ç' is no longer upper-cased by .toUpperCase from 7.1.0
8 participants