-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: backport fix to v8 bug in toUpper('ç') #9828
The head ref may contain hidden characters: "fix-\u00E7"
Conversation
54298b5
to
b1a4f0d
Compare
@srl295 AFAIK we will not land floating patches on V8 that have not landed upstream. once this has landed upstream it can be backported using this guide /cc @nodejs/v8 @ofrobots |
// Always run these. They should always pass, even if the locale | ||
// param is ignored. | ||
assert.strictEqual('Ç'.toLocaleLowerCase('el'), 'ç'); | ||
assert.strictEqual('Ç'.toLocaleLowerCase('tr'), 'ç'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to try 'lt' as well.
Otherwise, LGTM
@thealphanerd thanks. will wait for upstream fix. Version wise, this may need a backport . @ofrobots thanks, fixed. |
@srl295 why is this labelled with semver-minor. Seems like a bug fix to me. |
https://codereview.chromium.org/2533033003/ is a v8 CL to fix this issue. |
… and landed in v8 as https://chromium.googlesource.com/v8/v8/+/2f5da9a551785899ae1c899fd3c31b834a731e7d == v8/v8@2f5da9a |
This should be okay to review for landing onto I have requested a upstream merge for 5.5 and 5.6. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix should be formatted as a cherry-pick as per this guide: https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md
@srl295 are you able to update this following the guide mentioned above? It will need to include the original commit information, and also bump the V8 patch number. I'm more than happy to take it over if you like. |
@thealphanerd Let me see if I can do it… |
@ofrobots and @thealphanerd (and anyone) PTAL, updated as per guide mentioned above. |
@thealphanerd OK thanks. DO you want to land it in master also? If so please go ahead. |
once @ofrobots approves anyone can it 😁 |
@thealphanerd ok… also fixed the title, as it's no longer a workaround. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
CI passed despite reporting that arm failed. Landed in 6d3c5b7...e9b7291 |
Original commit message: Fix the uppercasing of U+00E7(ç) and U+00F7(÷) Due to a typo in runtime-i18n.js, 'ç'(U+00E7) was not uppercased while '÷'(U+00F7) was incorrectly uppercased to '×'(U+00D7). Add a comprehensive test for Latin-1 supplemental block (U+00A0 ~ U+00FF). (they're special-cased for speed-up and needs to have a test for the range.). TEST=intl/general/case-mapping BUG=v8:5681 Review-Url: https://codereview.chromium.org/2533033003 Cr-Commit-Position: refs/heads/master@{#41331} PR-URL: #9828 Fixes: #9785 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
This does not appear to affect v4 or v6 and as such I have added the |
Merged upstream into V8 5.5 and 5.6. |
* add test for ç/Ç in various locales PR-URL: nodejs#9828 Fixes: nodejs#9785 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
* add test for ç/Ç in various locales PR-URL: nodejs#9828 Fixes: nodejs#9785 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Original commit message: Fix the uppercasing of U+00E7(ç) and U+00F7(÷) Due to a typo in runtime-i18n.js, 'ç'(U+00E7) was not uppercased while '÷'(U+00F7) was incorrectly uppercased to '×'(U+00D7). Add a comprehensive test for Latin-1 supplemental block (U+00A0 ~ U+00FF). (they're special-cased for speed-up and needs to have a test for the range.). TEST=intl/general/case-mapping BUG=v8:5681 Review-Url: https://codereview.chromium.org/2533033003 Cr-Commit-Position: refs/heads/master@{#41331} PR-URL: #9828 Fixes: #9785 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Original commit message: Fix the uppercasing of U+00E7(ç) and U+00F7(÷) Due to a typo in runtime-i18n.js, 'ç'(U+00E7) was not uppercased while '÷'(U+00F7) was incorrectly uppercased to '×'(U+00D7). Add a comprehensive test for Latin-1 supplemental block (U+00A0 ~ U+00FF). (they're special-cased for speed-up and needs to have a test for the range.). TEST=intl/general/case-mapping BUG=v8:5681 Review-Url: https://codereview.chromium.org/2533033003 Cr-Commit-Position: refs/heads/master@{nodejs#41331} PR-URL: nodejs#9828 Fixes: nodejs#9785 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
* add test for ç/Ç in various locales PR-URL: nodejs#9828 Fixes: nodejs#9785 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Original commit message: Fix the uppercasing of U+00E7(ç) and U+00F7(÷) Due to a typo in runtime-i18n.js, 'ç'(U+00E7) was not uppercased while '÷'(U+00F7) was incorrectly uppercased to '×'(U+00D7). Add a comprehensive test for Latin-1 supplemental block (U+00A0 ~ U+00FF). (they're special-cased for speed-up and needs to have a test for the range.). TEST=intl/general/case-mapping BUG=v8:5681 Review-Url: https://codereview.chromium.org/2533033003 Cr-Commit-Position: refs/heads/master@{nodejs#41331} PR-URL: nodejs#9828 Fixes: nodejs#9785 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
* add test for ç/Ç in various locales PR-URL: nodejs#9828 Fixes: nodejs#9785 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Checklist
make -j8 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
deps - v8 floating patch
Description of change
https://bugs.chromium.org/p/v8/issues/detail?id=5681
Fixes: #9785