-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: refactor test-debug-args #9833
Conversation
Hmm failures seem related. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comment.
|
||
assert.notEqual(process.execArgv.indexOf('--debug-code'), -1); | ||
assert(!process.execArgv.includes('--debug-code')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The !
should be removed as the original check was process.execArgv.indexOf('--debug-code') != -1
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, that's certainly embarrassing. I must have tried to do a shortcut by only running the test I changed, and then pasted in the wrong file name or something. Fixing momentarily.
* indexOf() -> includes() * var -> const
Fixed. Let's try again. CI: https://ci.nodejs.org/job/node-test-pull-request/5032/ |
* indexOf() -> includes() * var -> const PR-URL: nodejs#9833 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Landed in cf2562b |
* indexOf() -> includes() * var -> const PR-URL: #9833 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* indexOf() -> includes() * var -> const PR-URL: nodejs#9833 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* indexOf() -> includes() * var -> const PR-URL: nodejs#9833 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* indexOf() -> includes() * var -> const PR-URL: #9833 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Checklist
make -j8 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
test debugger
Description of change