Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update test-zlib-truncated to use strictEqual #9858

Closed
wants to merge 1 commit into from
Closed

test: update test-zlib-truncated to use strictEqual #9858

wants to merge 1 commit into from

Conversation

bencripps
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Only test files updated.

Description of change

Updated test-zlib-truncated to use strictEqual. Added toUTF8 utility for corresponding tests.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 30, 2016
Trott
Trott approved these changes Nov 30, 2016
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is ✅

@Trott
Copy link
Member

Trott commented Nov 30, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5031/

@mscdex mscdex added the zlib Issues and PRs related to the zlib subsystem. label Nov 30, 2016
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 3, 2016
@bencripps @Trott
test: use strictEqual in test-zlib-truncated
8e1e15f 
PR-URL: nodejs#9858
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Dec 3, 2016

Landed in 8e1e15f. 🎉

@Trott Trott closed this Dec 3, 2016
addaleax pushed a commit that referenced this pull request Dec 5, 2016
@bencripps @addaleax
test: use strictEqual in test-zlib-truncated
eb369f6 
PR-URL: #9858
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@bencripps @addaleax
test: use strictEqual in test-zlib-truncated
fcc511a 
PR-URL: nodejs#9858
Reviewed-By: Rich Trott <rtrott@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@bencripps
test: use strictEqual in test-zlib-truncated
c7b66ae 
PR-URL: nodejs#9858
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@bencripps @MylesBorins
test: use strictEqual in test-zlib-truncated
fe6df5a 
PR-URL: #9858
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bencripps @Trott @mscdex @MylesBorins @addaleax @nodejs-github-bot