test: stream readable readableListening internal state #9864
Conversation
italoacasas
added
stream
| * `readableListening` | ||
| */ | ||
|
|
||
| const commun = require('../common.js'); |
| const stream = require('stream'); | ||
|
|
||
| /** | ||
| * Fiest test escenary, were we are going to call the |
There was a problem hiding this comment.
I'm not sure what this is supposed to say. Also, there is an extra space before the.
| /** | ||
| * Fiest test escenary, were we are going to call the | ||
| * `readable` event and test that `readableListening` state | ||
| * change succefully change to `true` |
| }); | ||
|
|
||
| // readableListening state should start in `false`. | ||
| assert.deepEqual(r._readableState.readableListening, false); |
There was a problem hiding this comment.
No need for deepEqual(). strictEqual() is good for comparing primitives.
| })); | ||
|
|
||
| // This should trigger some events in our | ||
| // first test ecenary |
There was a problem hiding this comment.
This can fit on the previous line I think.
| * value | ||
| */ | ||
|
|
||
| const r2 = new stream.Readable({ |
There was a problem hiding this comment.
Instead of having r, r2, etc., you can place the isolated test cases inside a block scope and reuse the same variable names.
| */ | ||
|
|
||
| const r2 = new stream.Readable({ | ||
| read: (asd) => {} |
| /** | ||
| * Testing Readable Stream internal state | ||
| * `readableListening` | ||
| */ |
| })); | ||
|
|
||
| // This should trigger some events in our | ||
| // second test case |
| * First test case, were we are going to call the | ||
| * `readable` event and test that `readableListening` state | ||
| * change successfully change to `true` | ||
| */ |
There was a problem hiding this comment.
can you condense this into a one-liner?
| * call the `readable` event and we expect | ||
| * that readableListening maintain his `false` | ||
| * value | ||
| */ |
There was a problem hiding this comment.
can you condense this into a oneliner?
|
nits resolved |
|
The linter seems failing. |
|
@mcollina I cannot find in the CI where is failing, can you see it ? |
|
Is |
|
I re-run the CI, is on queue. |
|
Really funny this error If i call I need to call common without the |
|
The CI failure looks not related with the PR, can someone confirm ? |
|
CI failure is unrelated. |
|
Landed 8dbf1af |
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
stream
Description of change
Adding test for the
readableListeningstate in stream.ReadableIssue related: #8683
cc: @mcollina