Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: update vm tests #9875

Closed
wants to merge 1 commit into from
Closed

Conversation

makenova
Copy link
Contributor

@makenova makenova commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tests

Description of change

change var to const or let
change assert.equal to assert.strictEqual

change var to const or let
change assert.equal to assert.strictEqual
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyller
Copy link
Member

imyller commented Dec 1, 2016

@mscdex mscdex added the vm Issues and PRs related to the vm subsystem. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
targos pushed a commit that referenced this pull request Dec 3, 2016
change var to const or let
change assert.equal to assert.strictEqual

PR-URL: #9875
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos
Copy link
Member

targos commented Dec 3, 2016

Landed in 8892433. I just edited the commit title.
Thanks for the contribution @makenova!

@targos targos closed this Dec 3, 2016
addaleax pushed a commit that referenced this pull request Dec 5, 2016
change var to const or let
change assert.equal to assert.strictEqual

PR-URL: #9875
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
change var to const or let
change assert.equal to assert.strictEqual

PR-URL: nodejs#9875
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
change var to const or let
change assert.equal to assert.strictEqual

PR-URL: nodejs#9875
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
change var to const or let
change assert.equal to assert.strictEqual

PR-URL: #9875
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants