Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clear out const/let #9878

Closed
wants to merge 1 commit into from
Closed

clear out const/let #9878

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions test/parallel/test-tls-ecdh.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,31 @@
'use strict';
var common = require('../common');
var assert = require('assert');
const common = require('../common');

if (!common.hasCrypto) {
common.skip('missing crypto');
return;
}
var tls = require('tls');
const assert = require('assert');
const tls = require('tls');

var exec = require('child_process').exec;
var fs = require('fs');
const exec = require('child_process').exec;
const fs = require('fs');

var options = {
const options = {
key: fs.readFileSync(common.fixturesDir + '/keys/agent2-key.pem'),
cert: fs.readFileSync(common.fixturesDir + '/keys/agent2-cert.pem'),
ciphers: '-ALL:ECDHE-RSA-AES128-SHA256',
ecdhCurve: 'prime256v1'
};

var reply = 'I AM THE WALRUS'; // something recognizable
const reply = 'I AM THE WALRUS'; // something recognizable

var server = tls.createServer(options, common.mustCall(function(conn) {
const server = tls.createServer(options, common.mustCall(function(conn) {
conn.end(reply);
}));

server.listen(0, '127.0.0.1', common.mustCall(function() {
var cmd = '"' + common.opensslCli + '" s_client -cipher ' + options.ciphers +
let cmd = '"' + common.opensslCli + '" s_client -cipher ' + options.ciphers +
` -connect 127.0.0.1:${this.address().port}`;

// for the performance and stability issue in s_client on Windows
Expand All @@ -34,7 +34,7 @@ server.listen(0, '127.0.0.1', common.mustCall(function() {

exec(cmd, common.mustCall(function(err, stdout, stderr) {
if (err) throw err;
assert.notEqual(stdout.indexOf(reply), -1);
assert(stdout.includes(reply));
server.close();
}));
}));