Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-child-process-stdio-inherit #9893

Closed
wants to merge 1 commit into from
Closed

test: refactor test-child-process-stdio-inherit #9893

wants to merge 1 commit into from

Conversation

WesTyler
Copy link
Contributor

@WesTyler WesTyler commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change
* assert.equal() -> assert.strictEqual()

@WesTyler
test: refactor test-child-process-stdio-inherit
0a97ecc 
    * assert.equal() -> assert.strictEqual()
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@Trott
Copy link
Member

Trott commented Dec 1, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5069/

@WesTyler
Copy link
Contributor Author

WesTyler commented Dec 4, 2016

Is it normal for a CI check to be pending for this long? Navigating into the details of test/windows-fanned, it seems like it may have actually finished successfully..

jasnell
jasnell approved these changes Dec 4, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you for the PR and for participating in the code-and-learn!

@jasnell
Copy link
Member

jasnell commented Dec 4, 2016

@WesTyler ... the CI gets tied up from time to time. The failure is unrelated to this PR.

jasnell pushed a commit that referenced this pull request Dec 4, 2016
@WesTyler @jasnell
test: refactor test-child-process-stdio-inherit
948ee11 
assert.equal() -> assert.strictEqual()

PR-URL: #9893
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Dec 4, 2016

Landed in 948ee11. Thank you!

@jasnell jasnell closed this Dec 4, 2016
addaleax pushed a commit that referenced this pull request Dec 5, 2016
@WesTyler @addaleax
test: refactor test-child-process-stdio-inherit
e070588 
assert.equal() -> assert.strictEqual()

PR-URL: #9893
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@WesTyler @addaleax
test: refactor test-child-process-stdio-inherit
a11f9ab 
assert.equal() -> assert.strictEqual()

PR-URL: nodejs#9893
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@WesTyler
test: refactor test-child-process-stdio-inherit
2cd7b69 
assert.equal() -> assert.strictEqual()

PR-URL: nodejs#9893
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@WesTyler @MylesBorins
test: refactor test-child-process-stdio-inherit
7615a0f 
assert.equal() -> assert.strictEqual()

PR-URL: #9893
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@WesTyler @MylesBorins
test: refactor test-child-process-stdio-inherit
78f7b65 
assert.equal() -> assert.strictEqual()

PR-URL: #9893
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@WesTyler @MylesBorins
test: refactor test-child-process-stdio-inherit
237e374 
assert.equal() -> assert.strictEqual()

PR-URL: #9893
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@santigimeno santigimeno santigimeno approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.