Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated test-cluster-send-deadlock.js to use assert.strictEqual #9902

Closed
wants to merge 1 commit into from
Closed

Updated test-cluster-send-deadlock.js to use assert.strictEqual #9902

wants to merge 1 commit into from

Conversation

daniel-pittman
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

tests

Description of change

Updated test-cluster-send-deadlock.js to change assert.equal to assert.strictEqual

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex mscdex added the cluster Issues and PRs related to the cluster subsystem. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@daniel-pittman
test: Changed assert.equal to assert.strictEqual
25a5072 
Updated test-cluster-send-deadlock.js to change
assert.equal to assert.strictEqual
@Trott
Copy link
Member

Trott commented Dec 1, 2016

Thanks for the contribution! CI: https://ci.nodejs.org/job/node-test-pull-request/5079/

jasnell pushed a commit that referenced this pull request Dec 5, 2016
@daniel-pittman @jasnell
test: Changed assert.equal to assert.strictEqual
1d6c264 
Updated test-cluster-send-deadlock.js to change
assert.equal to assert.strictEqual

PR-URL: #9902
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Dec 5, 2016

Landed in 1d6c264. thank you for the PR and for participating in the code-and-learn!

@jasnell jasnell closed this Dec 5, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 5, 2016
@daniel-pittman @Fishrock123
test: Changed assert.equal to assert.strictEqual
ae2bf0a 
Updated test-cluster-send-deadlock.js to change
assert.equal to assert.strictEqual

PR-URL: #9902
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@daniel-pittman @addaleax
test: Changed assert.equal to assert.strictEqual
7a228fe 
Updated test-cluster-send-deadlock.js to change
assert.equal to assert.strictEqual

PR-URL: nodejs#9902
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@daniel-pittman
test: Changed assert.equal to assert.strictEqual
0641264 
Updated test-cluster-send-deadlock.js to change
assert.equal to assert.strictEqual

PR-URL: nodejs#9902
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@daniel-pittman @MylesBorins
test: Changed assert.equal to assert.strictEqual
aaab510 
Updated test-cluster-send-deadlock.js to change
assert.equal to assert.strictEqual

PR-URL: #9902
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@daniel-pittman @MylesBorins
test: Changed assert.equal to assert.strictEqual
7aa95cf 
Updated test-cluster-send-deadlock.js to change
assert.equal to assert.strictEqual

PR-URL: #9902
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@daniel-pittman @MylesBorins
test: Changed assert.equal to assert.strictEqual
fd4999b 
Updated test-cluster-send-deadlock.js to change
assert.equal to assert.strictEqual

PR-URL: #9902
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@daniel-pittman @Trott @jasnell @lpinca @cjihrig @mscdex @MylesBorins @addaleax @imyller @nodejs-github-bot