Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Update vars to const/let & equal to strictEqual #9927

Closed
wants to merge 3 commits into from
Closed

test: Update vars to const/let & equal to strictEqual #9927

wants to merge 3 commits into from

Conversation

creatifyme
Copy link

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

Test

Description of change
  • Updating test to use ES2015 const/let instead of var
  • Updating assert.equal to assert.strictEquals

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Dec 1, 2016
not-an-aardvark
not-an-aardvark suggested changes Dec 1, 2016
View reviewed changes
Copy link
Contributor

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM, but may you please update the commit message to be <= 50 characters long?

(Alternatively, whoever lands this pull request can update the commit message.)

@creatifyme
Copy link
Author

@not-an-aardvark Ok, I've amended the commit message to be less than 50 chars

@jasnell
Copy link
Member

jasnell commented Dec 5, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5205/

@Trott
Copy link
Member

Trott commented Dec 6, 2016

One Raspberry Pi build failure in CI is unrelated.

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 6, 2016
@Trott
test: refactor test-fs-read-stream-resume
8be9d68 
Update vars to const/let & equal to strictEqual.

PR-URL: nodejs#9927
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member

Trott commented Dec 6, 2016

Landed in 8be9d68.
Thanks for the contribution! 🎉

@Trott Trott closed this Dec 6, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 6, 2016
@Fishrock123
test: refactor test-fs-read-stream-resume
84813fd 
Update vars to const/let & equal to strictEqual.

PR-URL: #9927
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@addaleax
test: refactor test-fs-read-stream-resume
09de714 
Update vars to const/let & equal to strictEqual.

PR-URL: nodejs#9927
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
test: refactor test-fs-read-stream-resume
60b7185 
Update vars to const/let & equal to strictEqual.

PR-URL: nodejs#9927
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@MylesBorins
test: refactor test-fs-read-stream-resume
71ab88c 
Update vars to const/let & equal to strictEqual.

PR-URL: #9927
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@MylesBorins
test: refactor test-fs-read-stream-resume
e8fe37e 
Update vars to const/let & equal to strictEqual.

PR-URL: #9927
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@MylesBorins
test: refactor test-fs-read-stream-resume
83dd2ec 
Update vars to const/let & equal to strictEqual.

PR-URL: #9927
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@creatifyme @jasnell @Trott @cjihrig @not-an-aardvark @mscdex @MylesBorins @addaleax @imyller @nodejs-github-bot