Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Change equal to strictEqual and pass delay to setTimeout #9938

Closed
wants to merge 3 commits into from
Closed

test: Change equal to strictEqual and pass delay to setTimeout #9938

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c78fb5
test: change equal to strictEqual, fix setTimeout
Dec 1, 2016
89b0369
Update timeout delay to 1ms
Dec 2, 2016
80c2aec
Update timeout to use mustCall
Dec 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions test/parallel/test-domain-exit-dispose.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
'use strict';
require('../common');
var common = require('../common');
var assert = require('assert');
var domain = require('domain');
var disposalFailed = false;

// no matter what happens, we should increment a 10 times.
var a = 0;
Expand All @@ -22,11 +22,7 @@ function err() {
function err2() {
// this timeout should never be called, since the domain gets
// disposed when the error happens.
setTimeout(function() {
console.error('This should not happen.');
disposalFailed = true;
process.exit(1);
});
setTimeout(common.mustCall(() => {}, 0), 1);

// this function doesn't exist, and throws an error as a result.
err3(); // eslint-disable-line no-undef
Expand All @@ -41,7 +37,6 @@ function err() {
}

process.on('exit', function() {
assert.equal(a, 10);
assert.equal(disposalFailed, false);
assert.strictEqual(a, 10);
console.log('ok');
});