Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test console fix assert equals #9942

Closed
wants to merge 4 commits into from

Conversation

mcrummey
Copy link

@mcrummey mcrummey commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
Affected core subsystem(s)

test

Description of change

using strictEquals instead of equals.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex mscdex added the console Issues and PRs related to the console subsystem. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@mcrummey mcrummey closed this Dec 2, 2016
@mcrummey mcrummey deleted the testConsoleFixAssertEquals branch December 2, 2016 20:27
@mcrummey
Copy link
Author

mcrummey commented Dec 2, 2016

Closed this PR because I merged the changes into PR #9873. Accidentally created two PRs when there should have been one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. console Issues and PRs related to the console subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants