test: const, let and strictEqual in test-tls-0 #9948
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imyller
added
code-and-learn
not-an-aardvark
approved these changes
Dec 1, 2016
cjihrig
approved these changes
Dec 4, 2016
jasnell
requested changes
Dec 5, 2016
| var cert = c.getPeerCertificate(); | ||
| assert.equal(cert.subjectaltname, | ||
| const cert = c.getPeerCertificate(); | ||
| assert.strictEqual(cert.subjectaltname, | ||
| 'DNS:google.com\0.evil.com, ' + |
There was a problem hiding this comment.
Can you please align the arguments here?
|
@jasnell To keep this moving, I addressed your nit on @flekmatik's behalf. PTAL and update your review if it's warranted. Thanks! |
|
ping @jasnell: Your nit has been addressed. Looks good to you now? |
italoacasas
approved these changes
Dec 22, 2016
jasnell
approved these changes
Dec 22, 2016
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 22, 2016
* var -> const, let * assert.equal() -> assert.strictEqual() PR-URL: nodejs#9948 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 004a100. Thanks for the contribution! 🎉 |
targos
pushed a commit
that referenced
this pull request
Dec 26, 2016
* var -> const, let * assert.equal() -> assert.strictEqual() PR-URL: #9948 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 28, 2016
* var -> const, let * assert.equal() -> assert.strictEqual() PR-URL: #9948 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
* var -> const, let * assert.equal() -> assert.strictEqual() PR-URL: #9948 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
* var -> const, let * assert.equal() -> assert.strictEqual() PR-URL: #9948 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jan 23, 2017
* var -> const, let * assert.equal() -> assert.strictEqual() PR-URL: #9948 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
* var -> const, let * assert.equal() -> assert.strictEqual() PR-URL: #9948 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 1, 2017
* var -> const, let * assert.equal() -> assert.strictEqual() PR-URL: #9948 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Just a fix for a test
Description of change
Using const instead of var and strictEqual instead of equal in test/parallel/test-tls-0-dns-altname.js