Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: crypto-hmac test assert.equal -> assert.strictEqual #9958

Closed

Commits on Dec 1, 2016

  1. Configuration menu
    Copy the full SHA
    d3b53a5 View commit details
    Browse the repository at this point in the history
  2. test: crypto-hmac fixed lint errors introduced by strictEquals

    because in 2 cases the assert.equals for several assertions
    had long arguments, those arguments were misaligned when changing
    to assert.strictEquals so this commit adds the extra space
    for alignment.
    
    in both cases, the final argument with prepended whitespace
    extends past the 80 char limit, so these args end up being split
    onto 2 lines
    eudaimos committed Dec 1, 2016
    Configuration menu
    Copy the full SHA
    280eef3 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2016

  1. test: crypto-hmac removed new lines from assertion messages

    in 2 cases the change to strictEquals caused extra indentation which
    made the concatenated assertion failure messages span 2 lines - these
    were switched to use template strings instead where they now fit onto
    a single line within the 80 char limit
    
    additionally updated the last 2 assertion messages using template
    strings in order to remain consistent.
    eudaimos committed Dec 7, 2016
    Configuration menu
    Copy the full SHA
    48a3380 View commit details
    Browse the repository at this point in the history