test: add mustCall to setTimeout #9984
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added mustCall to the setTimout inline function. Changed assert.equal to assert.strictEqual. Changed var for require modules to let.
imyller
added
the
code-and-learn
mscdex
reviewed
Dec 1, 2016
| serverConnection.end(); | ||
| clientConnection.end(); | ||
| echoServer.close(); | ||
| }, common.platformTimeout(100)); | ||
| },1), common.platformTimeout(100)); |
There was a problem hiding this comment.
There should be a space before the 1 here.
|
I think the commit message should either be changed to allude to the other changes being made or separate commits should be made. |
| var common = require('../common'); | ||
| var assert = require('assert'); | ||
| var net = require('net'); | ||
| let common = require('../common'); |
There was a problem hiding this comment.
why not const instead of let?
| serverConnection.end(); | ||
| clientConnection.end(); | ||
| echoServer.close(); | ||
| }, common.platformTimeout(100)); | ||
| },1), common.platformTimeout(100)); |
There was a problem hiding this comment.
nit: A space before 1
|
Fixed in: #9995 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Added mustCall to the setTimout inline function. Changed assert.equal
to assert.strictEqual. Changed var for require modules to let.