Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: changed assert.strict to assert.strictEqual() #9988

Closed
wants to merge 1 commit into from
Closed

test: changed assert.strict to assert.strictEqual() #9988

wants to merge 1 commit into from

Conversation

ashita92
Copy link
Contributor

@ashita92 ashita92 commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • [] documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

changed assert.equal() to assert.strictEqual()

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex
Copy link
Contributor

mscdex commented Dec 1, 2016 •
edited
Loading

Please see the commit message guidelines here.

@imyller
Copy link
Member

imyller commented Dec 1, 2016

@ashita92 Please replace subsystem: with test: in commit message and PR title.

@mscdex mscdex added the domain Issues and PRs related to the domain subsystem. label Dec 1, 2016
@imyller imyller added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. domain Issues and PRs related to the domain subsystem. and removed domain Issues and PRs related to the domain subsystem. labels Dec 1, 2016
@ashita92 ashita92 changed the title subsystem: changed assert.strict to assert.strictEqual() test: changed assert.strict to assert.strictEqual() Dec 1, 2016
@Trott
Copy link
Member

Trott commented Dec 9, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5346/

@Trott
Copy link
Member

Trott commented Dec 22, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5523/

@italoacasas
Copy link
Contributor

Landed 76c7220

italoacasas pushed a commit that referenced this pull request Dec 22, 2016
@ashita92 @italoacasas
test: change assert.strict to assert.strictEqual()
76c7220 
PR-URL: #9988
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@evanlucas evanlucas mentioned this pull request Jan 3, 2017
Merged
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
@ashita92 @evanlucas
test: change assert.strict to assert.strictEqual()
f4de757 
PR-URL: #9988
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
@ashita92 @evanlucas
test: change assert.strict to assert.strictEqual()
815b5bd 
PR-URL: #9988
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@ashita92 @MylesBorins
test: change assert.strict to assert.strictEqual()
ce4518b 
PR-URL: #9988
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@ashita92 @MylesBorins
test: change assert.strict to assert.strictEqual()
2968876 
PR-URL: #9988
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@ashita92 @MylesBorins
test: change assert.strict to assert.strictEqual()
ea069a6 
PR-URL: #9988
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@ashita92 @MylesBorins
test: change assert.strict to assert.strictEqual()
009a55b 
PR-URL: #9988
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Jan 24, 2017
Merged
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
@ashita92 @MylesBorins
test: change assert.strict to assert.strictEqual()
0e5ef41 
PR-URL: #9988
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
@ashita92 @MylesBorins
test: change assert.strict to assert.strictEqual()
b87ee26 
PR-URL: #9988
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. domain Issues and PRs related to the domain subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@ashita92 @mscdex @imyller @Trott @italoacasas @jasnell @lpinca @cjihrig @MylesBorins @nodejs-github-bot