Change var to const or let in test-child-process-ipc.js #9990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imyller
added
the
code-and-learn
|
@malenesok007 May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines. |
mscdex
added
the
child_process
|
Hi I have modify the commit message. Is there something I am missing? Thanks. |
malenesok007
force-pushed
the
myChanges
branch
from
9861cf2 to
ed87188
Compare
jasnell
approved these changes
Dec 5, 2016
silverwind
suggested changes
Dec 9, 2016
| let gotHelloWorld = false; | ||
| let gotEcho = false; | ||
|
|
||
| let child = spawn(process.argv[0], [sub]); |
There was a problem hiding this comment.
Linter error here:
error 'child' is never reassigned. Use 'const' instead prefer-const
|
Ping @malenesok007: Can you change the |
|
Because it was a straightforward lint fix, I made the change and pushed it to @malenesok007's branch. @silverwind Can you take a look and, if appropriate, update your review? Thanks! |
silverwind
approved these changes
Dec 24, 2016
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 24, 2016
Change var to const or let. Change assert.equal() to assert.strictEqual(). PR-URL: nodejs#9990 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
|
Landed in ff88a5a. |
targos
pushed a commit
that referenced
this pull request
Dec 26, 2016
Change var to const or let. Change assert.equal() to assert.strictEqual(). PR-URL: #9990 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 28, 2016
Change var to const or let. Change assert.equal() to assert.strictEqual(). PR-URL: #9990 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
Change var to const or let. Change assert.equal() to assert.strictEqual(). PR-URL: #9990 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
Change var to const or let. Change assert.equal() to assert.strictEqual(). PR-URL: #9990 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
Change var to const or let. Change assert.equal() to assert.strictEqual(). PR-URL: #9990 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
Change var to const or let. Change assert.equal() to assert.strictEqual(). PR-URL: #9990 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 1, 2017
Change var to const or let. Change assert.equal() to assert.strictEqual(). PR-URL: #9990 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change