Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update repl tests #9991

Closed
wants to merge 1 commit into from
+14 −14
Closed

test: update repl tests #9991

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: update repl tests 
change var to const or let
change assert.equal to assert.strictEqual
@makenova
makenova committed Dec 1, 2016
commit 7d8583652b4ccf5c24433b21decf04b0765fa954
28 changes: 14 additions & 14 deletions test/parallel/test-repl.js
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* eslint-disable max-len, strict */
var common = require('../common');
var assert = require('assert');
const common = require('../common');
const assert = require('assert');

common.globalCheck = false;
common.refreshTmpDir();
@@ -15,11 +15,11 @@ const prompt_npm = 'npm should be run outside of the ' +
'node repl, in your normal shell.\n' +
'(Press Control-D to exit.)\n';
const expect_npm = prompt_npm + prompt_unix;
var server_tcp, server_unix, client_tcp, client_unix, replServer;
let server_tcp, server_unix, client_tcp, client_unix, replServer;


// absolute path to test/fixtures/a.js
var moduleFilename = require('path').join(common.fixturesDir, 'a');
const moduleFilename = require('path').join(common.fixturesDir, 'a');

console.error('repl test');

@@ -30,7 +30,7 @@ global.invoke_me = function(arg) {

function send_expect(list) {
if (list.length > 0) {
var cur = list.shift();
const cur = list.shift();

console.error('sending ' + JSON.stringify(cur.send));

@@ -56,8 +56,8 @@ function strict_mode_error_test() {

function error_test() {
// The other stuff is done so reuse unix socket
var read_buffer = '';
var run_strict_test = true;
let read_buffer = '';
let run_strict_test = true;
client_unix.removeAllListeners('data');

client_unix.on('data', function(data) {
@@ -70,7 +70,7 @@ function error_test() {
if (read_buffer.indexOf(prompt_unix) !== -1) {
// if it's an exact match, then don't do the regexp
if (read_buffer !== client_unix.expect) {
var expect = client_unix.expect;
let expect = client_unix.expect;
if (expect === prompt_multiline)
expect = /[.]{3} /;
assert.ok(read_buffer.match(expect));
@@ -354,13 +354,13 @@ function tcp_test() {
});

server_tcp.listen(0, function() {
var read_buffer = '';
let read_buffer = '';

client_tcp = net.createConnection(this.address().port);

client_tcp.on('connect', function() {
assert.equal(true, client_tcp.readable);
assert.equal(true, client_tcp.writable);
assert.strictEqual(true, client_tcp.readable);
assert.strictEqual(true, client_tcp.writable);

send_expect([
{ client: client_tcp, send: '',
@@ -423,13 +423,13 @@ function unix_test() {
});

server_unix.on('listening', function() {
var read_buffer = '';
let read_buffer = '';

client_unix = net.createConnection(common.PIPE);

client_unix.on('connect', function() {
assert.equal(true, client_unix.readable);
assert.equal(true, client_unix.writable);
assert.strictEqual(true, client_unix.readable);
assert.strictEqual(true, client_unix.writable);

send_expect([
{ client: client_unix, send: '',