-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix assert.equal to strictEq #9999
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imyller
added
the
code-and-learn
Issues related to the Code-and-Learn events and PRs submitted during the events.
label
Dec 1, 2016
cjihrig
approved these changes
Dec 5, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code change LGTM.
jasnell
approved these changes
Dec 5, 2016
lpinca
approved these changes
Dec 9, 2016
Landed in 5a41a72. Thanks! |
lpinca
pushed a commit
that referenced
this pull request
Dec 16, 2016
* use assert.strictEqual() instead of assert.equal() PR-URL: #9999 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas
pushed a commit
that referenced
this pull request
Dec 17, 2016
* use assert.strictEqual() instead of assert.equal() PR-URL: #9999 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
cjihrig
pushed a commit
that referenced
this pull request
Dec 20, 2016
* use assert.strictEqual() instead of assert.equal() PR-URL: #9999 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 22, 2017
* use assert.strictEqual() instead of assert.equal() PR-URL: #9999 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
* use assert.strictEqual() instead of assert.equal() PR-URL: #9999 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
* use assert.strictEqual() instead of assert.equal() PR-URL: #9999 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
code-and-learn
Issues related to the Code-and-Learn events and PRs submitted during the events.
dgram
Issues and PRs related to the dgram subsystem / UDP.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make -j4 test
passesAffected core subsystem: test
On line 10: changed assert.equal to "assert.strictEqual(bytes, buf1.length + buf2.length);"