-
Notifications
You must be signed in to change notification settings - Fork 1k
closes #165: fix for navigation on 404 page #166
Conversation
There is a refactoring PR I'd wait for first. #157 |
Sure. Please let me know once the PR #157 is merged. I'll pull those changes so that you can proceed with the approval and merging. Thanks! |
/gcbrun |
Thanks for the PR, but it would be great if you can provide your description short enough, so that people can know whats your fix is for and what change is expected (I know you had given in the heading, but link in the description would be great!). Thanks! @KirankumarAmbati |
Co-Authored-By: KirankumarAmbati <kiran.chinna12520@gmail.com>
Thank you @antsmartian for the suggestion. I updated the description. Please let me know if that looks good. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
One suggestion below, but no worries if you want to take care of it on a follow-up PR.
@KirankumarAmbati #157 is finally merged. 🎉 |
FYI, the navigation is currently no more included on the 404 page (it may be reinstated... follow the discussion). |
Ya. I just noticed that but I feel navigation is more user-friendly than a blank 404 page. May be we can get back to the navigation section once all things settle down. |
@sagirk This PR is no more valid since the GraphQL part is removed from the 404 page. Closing it. |
Description of Changes:
Once a user lands on the 404 Page, he/ she is not able to migrate to any other page using any of the links. The UI is kind of freezed. On clicking any link, URL is getting updated but UI remains unchanged. My changes will address this issue.