Skip to content
This repository has been archived by the owner on Mar 25, 2018. It is now read-only.

404 on tracing module (API) #77

Closed
paulomcnally opened this issue Feb 9, 2015 · 15 comments
Closed

404 on tracing module (API) #77

paulomcnally opened this issue Feb 9, 2015 · 15 comments

Comments

@paulomcnally
Copy link
Contributor

http://nodejs.org/api/tracing.html

@robertkowalski
Copy link
Contributor

good catch! i opened a PR to adress the problem

robertkowalski added a commit to robertkowalski/node-v0.x-archive that referenced this issue Feb 9, 2015
@misterdjules
Copy link

@robertkowalski I don't see in this repository the PR you mention, and the problem seems to not be fixed. Could you please create it so that we can merge it and fix this issue?

Thanks!

@misterdjules misterdjules reopened this Feb 24, 2015
@robertkowalski
Copy link
Contributor

yes @paulomcnally closed the issue

still waiting for a review on nodejs/node-v0.x-archive#9172 - PTAL :)

@paulomcnally
Copy link
Contributor Author

@misterdjules
Copy link

@misterdjules
Copy link

@paulomcnally Thanks :)

The fix landed in nodejs/node-v0.x-archive@08a1192. With this fix and following our usual workflow, the API doc's table of content would be updated when node v0.12.1 is released. I would like to deploy this fix sooner than that though, as we still don't know when this release will happen.

@tjfontaine @robertkowalski It should be safe to rsync -r out/doc/ node@nodejs.org:~/web/nodejs.org/ right?

@misterdjules
Copy link

I deployed nodejs/node-v0.x-archive@08a1192 to nodejs.org to avoid having to wait for v0.12.1 to fix this annoying and confusing issue.

I cherry-picked nodejs/node-v0.x-archive@08a1192 and diffed the content of the generated api doc, and then ran rsync --dry-run to check which files would be changed. The only change were in the table of content, so I made the decision it was safe to deploy. More details in this gist.

Closing as the TOC at http://nodejs.org/api/ now does not include the tracing module anymore.

Thank you @paulomcnally and @robertkowalski!

@paulomcnally
Copy link
Contributor Author

I use this url to create local documentation https://github.com/nodenica/grunt-node-api-docs-responsive

https://nodejs.org/dist/v0.12.0/docs/api/index.json

tracing link exists on this source :/

@robertkowalski
Copy link
Contributor

@misterdjules did you port it to 0.12 ?

@misterdjules
Copy link

The fix has been merged into the v0.12 branch, but not into the v0.12.0-release branch. Thus, it's been deployed to http://nodejs.org/api/, but not to http://nodejs.org/dist/v0.12.0/docs/api.

The v0.12.0 release's artifacts should in my opinion remain intact, and the fix will be present in all subsequent v0.12.x releases.

@paulomcnally Is there a way for you to handle this issue for v0.12.0 in your application?

@paulomcnally
Copy link
Contributor Author

Yes @misterdjules for this version (only for this version) i use /api/index.json and not /dist/v0.12.0/docs/api/index.json.

@misterdjules
Copy link

@paulomcnally /api/index.json will change and will even eventually not point to a v0.12.x version, so you might want to handle this differently.

@paulomcnally
Copy link
Contributor Author

@misterdjules /api/index.json now it's for my custom app. The module use http://nodejs.org/dist/v0.12.0/docs/api/index.json

This solved on next version. From now create a tracing.html empty.

@misterdjules
Copy link

The problem is still present in http://nodejs.org/dist/v0.12.1/docs/api/ because the v0.12.1 release was branched off v0.12.0 and just added the OpenSSL upgrade, thus not including nodejs/node-v0.x-archive@08a1192.

http://nodejs.org/dist/v0.12.2/docs/api/ will definitely not have this problem, sorry for the inconvenience.

@paulomcnally
Copy link
Contributor Author

i know :/

Thanks @misterdjules

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants