Skip to content

Commit

Permalink
Fix: Update the img link of 'schedule.png' (#2056)
Browse files Browse the repository at this point in the history
We cannot see the 'schedule.png', so according to this submit
(nodejs/Release@2bf2ea3), it seems the img was removed and we've used
'schedule.svg' instead.

The reason why I use the parameter `?sanitize=true` is that we MUST make
sure that the response type should be of img (Content-Type should be
`img/svg+xml` instead of `text/plain`).

For more about svg rendering on GitHub's server, please see these
related posts:

1. isaacs/github#316 (comment)
2.
https://stackoverflow.com/questions/13808020/include-an-svg-hosted-on-github-in-markdown
(See 'Linking to RAW files (Does not work)').

Fix for: #2055
  • Loading branch information
Maledong authored and fhemberger committed Feb 9, 2019
1 parent 5747b3a commit 0232462
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion layouts/about-release-schedule.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
{{{ contents }}}

<p>
<img alt="{{ title }}" src="https://raw.githubusercontent.com/nodejs/Release/master/schedule.png">
<img alt="{{ title }}" src="https://raw.githubusercontent.com/nodejs/Release/master/schedule.svg?sanitize=true">
</p>

{{{ release-schedule }}}
Expand Down

0 comments on commit 0232462

Please sign in to comment.