Make the release-post script more tolerant (#838)

Fixes: #837
nodejs · Jul 23, 2016 · e228b32 · e228b32
1 parent 9b8861e
commit e228b32
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/scripts/release-post.js b/scripts/release-post.js
@@ -103,7 +103,7 @@ function fetchChangelog (version) {
     const rxSection = new RegExp(`<a id="${version}"></a>\\n([\\s\\S]+?)(?:\\n<a id="|$)`)
     const matches = rxSection.exec(data)
     return matches
-      ? matches[1]
+      ? matches[1].trim()
       : Promise.reject(new Error(`Couldn't find matching changelog for ${version}`))
   })
 }

diff --git a/tests/scripts/release-post.test.js b/tests/scripts/release-post.test.js
@@ -117,6 +117,8 @@ test('fetchChangelog(<version>)', (t) => {
       .replyWithFile(200, changelogFixture)
 
     releasePost.fetchChangelog('4.1.1').then((changelog) => {
+      t.true(changelog.charAt(changelog.length - 1) !== '\n')
+      t.true(changelog.charAt(0) !== '\n')
       t.true(changelog.includes('Fixed a bug introduced in v4.1.0'))
       t.true(github.isDone(), 'githubusercontent.com was requested')