-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working Group page grammar and style fixes #1012
Conversation
Verified that the package manager install steps work on the newest version of amazon linux
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I REALLY like this polishing!! however, this page (as the comment in there says):
Information here should mostly mirror: https://github.com/nodejs/TSC/blob/master/WORKING_GROUPS.md
So, that document should be changed first and get approved/PRd. Any chance you're up for doing a PR to that doc?
@williamkapke Ah, thanks for mentioning that. Looks like there are two separate documents for top-level and core working groups. I'll make PR's for both and reference this PR in them. Thanks! |
@williamkapke PR's complete. Also, updated the diagnostics section to match the core WG document. Looks like it actually was updated, but the site didn't stay in sync. |
@williamkapke Both PR's for the other working group documents have been merged. You good with merging this PR? |
I noticed some inconsistencies in the Working Group page and thought it would benefit from a cleanup. The focus was on making the document feel like a cohesive whole and remove discrepencies of style and structure between each section.
Here are some of the changes I made. Feedback around any of these is appreciated!