nodejs-docker-webapp - Add comment for production build #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
reviewed
Oct 31, 2017
| @@ -105,6 +105,8 @@ COPY package.json . | |||
| # COPY package.json package-lock.json ./ | |||
|
|
|||
| RUN npm install | |||
| # If you are building your code for production | |||
| # RUN npm install --only=production | |||
There was a problem hiding this comment.
Isn't it better to use the NODE_ENV env var?
There was a problem hiding this comment.
Good point but an environment variable affects the following commands.
But I'm ok for changing it using ARG NODE_ENV=production
There was a problem hiding this comment.
It can be set when running docker run as per best practices.
There was a problem hiding this comment.
Yes but npm install is made during the build time. The "-e" option is available only at run time.
If you prefer I can suggest to build the image using --build-args NODE_ENV=production in the best practise
There was a problem hiding this comment.
Yes you are right, I have no strong opinions.
lpinca
approved these changes
Oct 31, 2017
daxlab
approved these changes
Nov 1, 2017
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as titled
If it is ok, I'll reproduce this changes in italian language (or using google translate in the others)