-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
French translation of Downloads page #1550
Conversation
Eg: Source Code, Windows Binary etc.
@oncletom thanks for the effort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merci beaucoup! Thanks for the effort!
Few nits to correct, but I'll call for @nodejs/nodejs-fr to check the rest!
downloads: | ||
headline: Téléchargements | ||
lts: LTS | ||
current: Actuelle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'aurais plutôt dit "Courante". Plus littéral mais aussi plus juste AMHA.
lts: LTS | ||
current: Actuelle | ||
tagline-current: Dernières fonctionnalités | ||
tagline-lts: Recommandé pour la plupart des utilisateurs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Recommandée", au féminin plutôt, puisqu'on parle d'une version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Là aussi je me suis basé sur ce qu'il y avait déjà de traduit sur la page d'accueil : https://nodejs.org/fr/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Au temps pour moi, on peut justifier qu'on parle d'un téléchargement!
locale/fr/download/current.md
Outdated
tagline-lts: Recommandé pour la plupart des utilisateurs | ||
display-hint: Afficher les téléchargement pour Node | ||
intro: > | ||
Téléchargez le code source de Node.js ou pour votre système d'exploitation et commencez à développer dès aujourd'hui. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
La formulation me paraît étrange ici. Il ne manque pas un mot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il y a un mot en trop surtout :-) "ou"
locale/fr/download/current.md
Outdated
display-hint: Afficher les téléchargement pour Node | ||
intro: > | ||
Téléchargez le code source de Node.js ou pour votre système d'exploitation et commencez à développer dès aujourd'hui. | ||
currentVersion: Dernière version Actuelle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Même chose que plus haut, "Courante"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je me suis contenté de reprendre la traduction existante, Cf. ce qu'on trouvera déjà ici : https://nodejs.org/fr/
En regardant d'autres sites parlant de "version", je vois aussi bien "Courant" qu'Actuelle.
locale/fr/download/current.md
Outdated
additional: | ||
headline: Autres plate-formes | ||
intro: > | ||
Les membres de la communauté Node.js maintiennent des installeurs de Node.js pour d'autres plate-formes. Veuillez noter que ces téléchargements ne sont pas maintenus par l'équipe principale de Node.js et n'offrent pas forcément la même qualité que les téléchargements officiels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"qualité" me semble potentiellement un peu péjoratif. Mais je sèche un peu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. La version anglaise est the same build level. Tu penses à un autre terme lié à "niveau" ? (chais pas, "niveau" ça me paraît bizarre…).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est ce que j'ai vu oui, mais niveau me paraît aussi tendancieux en français. Stabilité?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouais, ou même niveau de support ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ca me semble mieux oui!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top. On part sur ça :-) merci pour ton aide !
LinuxPowerSystems: Linux sur Power Systems | ||
LinuxSystemZ: Linux sur System z | ||
AIXPowerSystems: AIX sur Power Systems | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mêmes remarques que pour le précédent fichier 🙂
locale/fr/download/current.md
Outdated
current: Actuelle | ||
tagline-current: Dernières fonctionnalités | ||
tagline-lts: Recommandé pour la plupart des utilisateurs | ||
display-hint: Afficher les téléchargement pour Node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
téléchargements
locale/fr/download/index.md
Outdated
current: Actuelle | ||
tagline-current: Dernières fonctionnalités | ||
tagline-lts: Recommandé pour la plupart des utilisateurs | ||
display-hint: Afficher les téléchargement pour Node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
téléchargements
Okay folks I have made changes as you spotted issues. How is it now? Is it good enough to be merged? |
/cc @nodejs/nodejs-fr @cedced19 Please do a final review, so we can merge this. |
For me it's good! |
Sorry, totally forgot about this. Merging now, thank you! |
Pardon my French! As part of the writing of this book, I wanted to offer the french audience a translated Downloads page 🙂
The PR has two commits:
The latter contains default strings (in English and in French) for the new translation keys.
I was a bit confused by the location of translation strings (sometimes in
locale/*/site.json
, sometimes directly inlocale/**/*.md
). I am happy to relocate them if I did not do the right move.