Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing translation #1642

Merged
1 commit merged into from
May 1, 2018
Merged

Add missing translation #1642

1 commit merged into from
May 1, 2018

Conversation

pin3da
Copy link
Contributor

@pin3da pin3da commented Apr 30, 2018

Add missing translation #1608

Add missing translation nodejs#1608
@@ -12,7 +12,7 @@ downloads:
intro: >
Descargue el código fuente de Node.js o un instalador pre-compilado para su plataforma, y comience a desarrollar hoy.
currentVersion: Versión actual
buildInstructions: Building Node.js from source on supported platforms
buildInstructions: Compilando Node.js desde el código fuente en las plataformas soportadas
Copy link
Contributor

@WaleedAshraf WaleedAshraf May 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for fixing this. :)
I don't know Spanish,
But Google translator (which is not that accurate) is translating this Spanish into English as:

Compiling Node.js from source code on supported platforms.

And when I do original English -> Spanish

Construyendo Node.js desde la fuente en las plataformas compatibles.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the translation suggested in #1608. I can make any change if needed 👍

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine as it is, native speakers already agreed about this translation in #1608

Copy link
Contributor

@WaleedAshraf WaleedAshraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍👍

@ghost ghost merged commit 738ed97 into nodejs:master May 1, 2018
@pin3da pin3da mentioned this pull request May 6, 2018
pin3da added a commit to pin3da/nodejs.org that referenced this pull request May 7, 2018
I recently added the same translation for "current.md" in nodejs#1642, I just noted
that is missing here too.
ghost pushed a commit that referenced this pull request May 9, 2018
I recently added the same translation for "current.md" in #1642, I just noted
that is missing here too.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants