Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update zh-cn locale #1682

Merged
merged 2 commits into from
Jun 14, 2018
Merged

update zh-cn locale #1682

merged 2 commits into from
Jun 14, 2018

Conversation

willin
Copy link
Contributor

@willin willin commented Jun 7, 2018

No description provided.

@fhemberger
Copy link
Contributor

/cc @nodejs/nodejs-cn

@wongzigii
Copy link

LGTM 👍

Copy link
Contributor

@marswong marswong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -11,23 +11,23 @@ downloads:
display-hint: Display downloads for
intro: >
在你的平台上下载 Node.js 源码或预编译安装包,然后即可马上进行开发。
currentVersion: 当前版本
currentVersion: 当前最新版本
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当前最新意思相近,current当前比较匹配,最新latest更配

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

两者区分,一个是当前最新版本,一个是当前 LTS(长期支持)版本。最新是一种强调,与英文原版保持一致。

Copy link

@ghost ghost Jun 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The level of a good translation is something of clear, fully-understood meaning with fewer words in different kinds of cultures. So before translations we should have a deep understanding of them and try to translate them one by one according to proper nature of understanding:)

For example:The LTS stands for Long Term Support (For details, see: https://en.wikipedia.org/wiki/Long-term_support). And the Current here is beta-like version with latest new features as experiments (Maybe they will be removed or changed later). And this implicit meaning is easily taken by foreigners but not easily by Chinese people (For 1st sight, they don't know what LTS is and cannot tell the difference between LTS and Current. Most of them may download the latter).

So all in all, I perfer to translate them as:

1)LTS:正式版 ( A fully stable, released version that is ALWAYS maintained by fixing bugs, a long term support for more years……ect).
2)Current:尝鲜版(A testable version that enhances something newly with new things coming, but NOT SURE whether they will be removed or changed in the future).

And this will easily be understood by Chinese people and choose which to download.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Maledong so what you have suggested make sense to me, but it can lead to more confusion rather than clarification, since LTS is a widely accepted in opensource community. People tends to use Ubuntu LTS all the time, even we don't introduce a good translation.

Copy link

@ghost ghost Jun 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that just depends on which aspect you are on:)

But according to the actual result, many of us will look for what LTS is before they know about it means when download. Even this is a forever meaning in open-source env.

I only want to make most of us (no matter whether he/she programs or not). When download Nodejs, he/she will easily understand what it means.

And what's more——What about keeping the LTS like this following:

1)正式版(LTS)。
2)尝鲜版。

MacOSBinary: macOS Binary
LinuxBinaries: Linux Binaries
SourceCode: Source Code
WindowsInstaller: Windows 安装器
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不知道安装包安装程序是否会更好?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

安装包 is much better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可能吧,但是微软网站上遇到这个词大多数都是翻译为安装器。。。

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

安装包 +1

officialDockerImage: Official Node.js Docker Image
SunOSBinaries: SunOS 二进制文件
DockerImage: Docker 镜像
officialDockerImage: 官方 Node.js Docker 镜像
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里有点拗口,按照汉语语法:“Node.js 官方 Docker 镜像” 比较适合点

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marswong It should really be what he suggested. Here "official" refers to "Docker official", not "Node.js" official. And IMO "Docker 官方提供的 Node.js 镜像" makes more sense, but actually the English original version didn't make this clear too.

@@ -32,7 +32,7 @@
},
"about": {
"link": "about",
"text": "关于我们",
"text": "关于",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里建议保留我们,国际惯例

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

并没有吧,“关于我们”已经是考古词了

}
},
"docs": {
"link": "docs",
"text": "文档",
"es6": {
"link": "docs/es6",
"text": "ES6 相关"
"text": "ES6 及更高"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里建议保留英文ES6会好点,或者用更详细的ES6 特性是否会好些?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep es6 as what it is to make it better to understand

@@ -121,7 +123,7 @@
},
"blog": {
"link": "blog",
"text": "博客"
"text": "新闻"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议保留博客新闻的含义要更严谨些,blog 的严谨性还是差了不少

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

依然是中英对照,英文翻译为 News,实际博客中发布的也都是新闻。

Copy link

@laosb laosb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented. And I'm also wondering why you changed the lock file. It is not needed for updating translation IMO.

@marswong 's advice should also be taken into consideration.

MacOSBinary: macOS Binary
LinuxBinaries: Linux Binaries
SourceCode: Source Code
WindowsInstaller: Windows 安装器
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

安装包 is much better.

@@ -11,23 +11,23 @@ downloads:
display-hint: Display downloads for
intro: >
在你的平台上下载 Node.js 源码或预编译安装包,然后即可马上进行开发。
currentVersion: 当前版本
currentVersion: 最新长期支持版本
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use 最新 for "current". And seems nothing indicates it's LTS here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about “当前长期支持版本”?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willin currentVersion 指的不是 LTS 版本,因此 当前长期支持版本 是错误的。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

两个文件中都有 currentVersion 字段,表述的意思是不一样的。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当前版本

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

麻烦先对照英文翻译看一下。- -!

@willin
Copy link
Contributor Author

willin commented Jun 12, 2018

@laosb npm i auto updated...

@laosb
Copy link

laosb commented Jun 14, 2018

@fhemberger Will package-lock.json updates be accepted in a localization PR? If so then this PR is LGTM.

@fhemberger
Copy link
Contributor

@laosb Sure, you're right, it's not perfect but we'll have to update package-lock.json at some point. ;)

It's okay for me, so I'm merging this PR.
@willin Thanks for your effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants