Use js 'standard' formatter on pre-commit #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,7 +8,8 @@ | |||
| "serve": "node build.js serve", | |||
| "lint": "eslint scripts build.js", | |||
There was a problem hiding this comment.
Remove the old lint script and explicit eslint dep below?
fhemberger
force-pushed
the
standard-js
branch
from
3b12d89
to
4411170
Compare
|
LGTM |
|
|
NOTICE: Don't reformat scripts in ./static (may be already minified)
fhemberger
force-pushed
the
standard-js
branch
from
4411170
to
400c32f
Compare
|
Removed |
| `https://github.com/joyent/node/blob/${version}/ChangeLog`; | ||
| }; | ||
| return semver.gte(version, '1.0.0') | ||
| ? `https://github.com/nodejs/io.js/blob/${version}/CHANGELOG.md` |
There was a problem hiding this comment.
shouldn't this be https://github.com/nodejs/node/blob/${version}/CHANGELOG.md?
6 tasks
|
@nodejs/website Should we merge this? |
|
+1 |
fhemberger
added a commit
that referenced
this pull request
Sep 21, 2015
Use js 'standard' formatter on pre-commit
|
👏 |
This was referenced Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #157 and #159.