Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Spanish docs index page with the English version #1851

Merged
merged 4 commits into from
Oct 28, 2018

Conversation

academo
Copy link
Contributor

@academo academo commented Oct 22, 2018

I noted the docs index page of the Spanish website is a bit out of date and I want to update them.

I also want to update other parts of the docs and I'll do so in further pull requests. If you think I should do a single big pull request please let me know.

Note I changed the word "Características" by "Funcionalidades" I am not sure of this and advice is welcome.

This syncs the docs index content with the English version adding the new "Guides" sections.
Missed a translation when I copied the updated list of links
locale/es/docs/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Tsuna-mi Tsuna-mi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks

@Tsuna-mi Tsuna-mi added the i18n Issues/PRs related to the Website Internationalisation label Oct 24, 2018
@Tsuna-mi
Copy link
Contributor

Some help, please..

cc @nodejs/nodejs-es

@fhemberger
Copy link
Contributor

@Tsuna-mi @academo Is this PR good for merging or do you still need a hand with the review?

@academo
Copy link
Contributor Author

academo commented Oct 28, 2018

@fhemberger if no one else has comments it can be merged

@fhemberger fhemberger merged commit fe4513a into nodejs:master Oct 28, 2018
@fhemberger
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Issues/PRs related to the Website Internationalisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants