fix Edit on GitHub #1853
fix Edit on GitHub #1853
Conversation
build.js
Outdated
| const contents = file.contents.toString().replace(/<h1>(.+)<\/h1>/, ($1, $2) => { | ||
| return `<a class="edit-link" href="${url}">Edit on GitHub</a> <h1>${$2}</h1>` | ||
| const contents = file.contents.toString().replace(/<h1(.*?)>(.*?)<\/h1>/, ($1, $2, $3) => { | ||
| return `<a class="edit-link" href="${url}">Edit on GitHub</a> <h1>${$3}</h1>` |
There was a problem hiding this comment.
perhaps h1 props should be hold. like this:
return `<a class="edit-link" href="${url}">Edit on GitHub</a> <h1${$2}>${$3}</h1>`
build.js
Outdated
| @@ -185,8 +185,8 @@ function githubLinks (options) { | |||
| const file = files[path] | |||
| const url = `https://github.com/nodejs/nodejs.org/edit/master/locale/${options.locale}/${path.replace('.html', '.md')}` | |||
|
|
|||
| const contents = file.contents.toString().replace(/<h1>(.+)<\/h1>/, ($1, $2) => { | |||
| return `<a class="edit-link" href="${url}">Edit on GitHub</a> <h1>${$2}</h1>` | |||
| const contents = file.contents.toString().replace(/<h1(.*?)>(.*?)<\/h1>/, ($1, $2, $3) => { | |||
There was a problem hiding this comment.
The callback signature was a bit misleading, should be (match, $1, $2).
You can also get rid of the first capture group (since it's unused). /<h1[^>]+>(.*?)<\/h1>/
There was a problem hiding this comment.
Thanks for your help. So I don't need to change it anymore right ?
There was a problem hiding this comment.
Yes, we're good now. ;)
|
@ZYSzys, when you open a PR there's a checkbox named "Allow edits from maintainers." git push https://github.com/zys-contribs/nodejs.org edit-on-github |
|
@refack Understand now, thanks very much！ |
Now:
After fixed,
Edit on GitHubshows at right side.