-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Add the missing versions of Nodejs APIs' links #1865
Conversation
Notice: This can be postponed until Nodejs 8.x is retired from LTS in maintance state, because I've |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding v10 too ?
Good question! Nodejs v10.X will be the active LTS since 2018-10-30 (See:https://github.com/nodejs/Release#release-schedule). So it shoudn't be a previous version in my mind. But what confuses me is:Since 2018-10-30 v10 will take place of v8.X, will v8.X be the previous version? I have to put it there but as you know, v8 at that time is still in Active LTS……So how to cope with two versions of Nodejs (both v8 and v10 will be ACTIVE LTS after Oct 2018)? |
@Maledong keep it as is. It's how it should be as soon as 10 will be tagged as LTS. |
@lpinca:OK, So now I'll keep v8 in the previous list :) |
1) Missing the v8, v9 links of doc. 2) Fix the site.json in `fa`, add `rtl` and `locale` attributes.
fa
, addrtl
andlocale
attributes.