Update built-in debugger link to latest #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhemberger
approved these changes
Nov 26, 2018
refack
reviewed
Nov 26, 2018
richardlau
reviewed
Nov 26, 2018
|
Find that it's indeed the |
fhemberger
suggested changes
Dec 19, 2018
There was a problem hiding this comment.
@ZYSzys Please revert the changes, as it's indeed the legacy debugger.
I only noticed, that in the Korean version, links to the "Built-in Debugger" point to
- https://nodejs.org/docs/latest/api/debugger.html (comment)
- https://github.com/nodejs/node/blob/master/lib/_debugger.js
So these links should be replaced with https://nodejs.org/dist/latest-v6.x/docs/api/debugger.html, as in the other languages.
If I'm not mistaken, this should be the only remaining change.
ZYSzys
force-pushed
the
latest-debugger
branch
from
28cf11b
to
7d3c588
Compare
|
@fhemberger 👌Reverted and updated the link of "Built-in Debugger" in the Korean version. |
fhemberger
approved these changes
Dec 19, 2018
|
@ZYSzys Thanks! 👍 |
This was referenced Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update built-in debugger link to the latest in guides/debugging-getting-started.