Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add link to installation instructions for Linux #1931

Merged
merged 2 commits into from
Dec 12, 2018
Merged

Conversation

ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Dec 8, 2018

Fix: #1926

@ZYSzys
Copy link
Member Author

ZYSzys commented Dec 8, 2018

@fhemberger BTW, do we need to /cc some teams to translate the link text ?

@fhemberger
Copy link
Contributor

@ZYSzys Awesome, thank you!

Regarding translation, we could either cc every translation team or active translators will pick up the change on their own. We need to come up with a better way to handle website updates for translators anyway (possibly even before the relaunch).

/cc @nodejs/i18n

@ZYSzys
Copy link
Member Author

ZYSzys commented Dec 12, 2018

@fhemberger Hi, because of the nonactive at present, I just make the text keep in English if it's not translated.

Copy link
Contributor

@fhemberger fhemberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just add

    "install-on-linux": {
      "text": "Installing Node.js via binary archive on Linux"
    }

to all locale/*/site.json instead.

@ZYSzys
Copy link
Member Author

ZYSzys commented Dec 12, 2018

@fhemberger Done :)

@fhemberger
Copy link
Contributor

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants