-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove several questionable links from get-involved #1964
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Trott Thanks, +1 on removing those links. Could you please remove them in the other languages as well? |
This was referenced Dec 27, 2018
lpinca
approved these changes
Dec 31, 2018
remove several questionable links for ca
remove several questionable links for es
remove several questionable links for fa
remove several questionable links for fr.
remove several questionable links for pt-br.
remove several questionable links for uk
remove several questionable links for zh-CN.
remove several questionable links for zh-TH.
@nodejs/localization:Plz check your own localizations because I've just copied from the title of the 'get-involved', if there's anything wrong, just edit from Trott:questionable |
fhemberger
approved these changes
Jan 1, 2019
Thank you! |
This was referenced Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to see us weed this page more. There should be a much smaller number of links. Only durable, high-quality links should be listed. Otherwise, it reflects badly on the website and the project. No one will maintain the list and users will have a bad experience.
For example: Right now, if you click on the Nicaraqua Node.js Community link, you will be sent to a placeholder screen that tries to sell you car insurance.
Meanwhile, the Vietnam Node.js Community link is broken, the Korean link is questionable (seems to link to an out-of-date version of https://nodejs.org/ko/blog/), the Iranian link seems to be to an even more out-of-date version of the website, many of the others don't appear to be community links at all but are people's personal blogs which often have not been updated in years, the Australian site has an invalid cert...
Let someone else curate a living list that tries to be comprehensive. (Maybe someone can start one of those "Awesome" lists on GitHub for Node.js community/getting-involved stuff if there isn't one already.) The website is a poor choice of venue for that kind of thing.
This page needs fewer things, not more, IMO.