Remove stale resources from get-involved #1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How To Node has not been updated in over two years. A lot has happened in Node.js in that time. Remove it from the list.
NodeUp is awesome, but there was one episode in all of 2018. It's also questionable that it occurs in a list with 7 other resources that are all officially blessed. It gives the impression that NodeUp is official. It is not. Remove NodeUp from the list.
ghost
requested review from
vsemozhetbyt
approved these changes
Dec 29, 2018
|
@Trott Could you please check if those links exist in the other languages as well and remove them? |
lpinca
approved these changes
Dec 31, 2018
added 6 commits
January 1, 2019 08:16
Remove stale resources from get-involved for the Chinese version.
Remove stale resources from get-involved for UK
Remove stale resource for Fr
Remove stale resource for es
Remove stale resource for fa (English version, not translated yet).
Remove stale for Traditionl Chinese
|
@fhemberger , @Trott：I've helped to remove from other languages, so this can be merged :) |
ZYSzys
approved these changes
Jan 1, 2019
added 3 commits
January 1, 2019 12:06
Remove stale resources for ca
Remove stale resources for pt-br
Add spaces between the Traditional Chinese
Trott
commented
Jan 1, 2019
| @@ -24,6 +23,8 @@ Node.js 是個包容的大家庭，我們鼓勵用戶一展長才。若你想[ | |||
| - [官方 API 參考文件](/api)中詳細介紹了 Node API。 | |||
| - [NodeSchool.io](http://nodeschool.io) 以互動命令列的方式，教會你 Node.js 的概念。 | |||
| - [Stack Overflow 上的 Node.js 標籤](http://stackoverflow.com/questions/tagged/node.js)搜羅了每日新資訊。 | |||
| - [開發社區上的 Node.js 標籤](https://dev.to/t/node) 是一個共亯 Node.js項目、文章和教程，以及開始討論、並接受與 Node.js 相關的主題。歡迎所有技能級別的開發人員參與。 | |||
| - [Nodeiflux](https://discordapp.com/invite/vUsrbjd) 是一個 Nodejs 後端開發者在 Discord 上互相支援的友好社區。 | |||
There was a problem hiding this comment.
Why were these resources added in this commit? Was this a mistake?
There was a problem hiding this comment.
Oh, I see, they appear in the other lists in other en and other languages, so this just syncs up the lists. 👍
Thanks! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How To Node has not been updated in over two years. A lot has happened
in Node.js in that time. Remove it from the list.
NodeUp is awesome, but there was one episode in all of 2018. It's also
questionable that it occurs in a list with 7 other resources that are
all officially blessed. It gives the impression that NodeUp is official.
It is not. Remove NodeUp from the list.